nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-17 00:18:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: only resolve items when item_group/brand filter is set

Browse Source
This commit is contained in:
Nabin Hait
2026-07-02 17:10:19 +05:30
parent 3092c920ff
commit e0b0926dff
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
erpnext/selling/report/sales_person_wise_transaction_summary/sales_person_wise_transaction_summary.py
View File

@@ -226,12 +226,14 @@ def get_entries(filters):
st.sales_person.isin(frappe.qb.from_(sp).select(sp.name).where((sp.lft >= lft) & (sp.rgt <= rgt)))
)
items = get_items(filters)
if items:
# only resolve items when an item_group/brand filter is set; otherwise get_items
# would return every item in the system and add a huge IN() clause on each run
if filters.get("item_group") or filters.get("brand"):
items = get_items(filters)
if not items:
# the item_group/brand filter matched nothing -> no rows
return []
query = query.where(dt_item.item_code.isin([d[0] for d in items]))
elif filters.get("item_group") or filters.get("brand"):
# item_group/brand filter matched nothing -> no rows
return []
query = query.orderby(st.sales_person).orderby(dt.name, order=frappe.qb.desc)