nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-15 09:53:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(subcontracting): release raw-material reservation when closing a subcontracting order

Browse Source 
the bin reserved-qty recalc filtered out closed purchase orders but not
closed subcontracting orders, so closing a partially-received sco kept the
reservation for the unreceived qty and left projected qty understated.
apply the same closed-status filter to the subcontracting order path.
This commit is contained in:
Sudharsanan11
2026-07-25 23:54:52 +05:30
parent f077d2edc0
commit db91a79d31
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/stock/doctype/bin/bin.py
View File

@@ -164,11 +164,8 @@ class Bin(Document):
& (subcontract_order.name == supplied_item.parent) & (subcontract_order.name == supplied_item.parent)
& (subcontract_order.per_received < 100) & (subcontract_order.per_received < 100)
& (supplied_item.reserve_warehouse == self.warehouse) & (supplied_item.reserve_warehouse == self.warehouse)
& ( & (subcontract_order.status != "Closed")
((subcontract_order.status != "Closed") & (subcontract_order.docstatus == 1)) & (subcontract_order.docstatus == 1)
if subcontract_doctype == "Purchase Order"
else (subcontract_order.docstatus == 1)
)
) )
reserved_qty_for_sub_contract = ( reserved_qty_for_sub_contract = (
@@ -203,6 +200,7 @@ class Bin(Document):
else ( else (
(Coalesce(se.subcontracting_order, "") != "") (Coalesce(se.subcontracting_order, "") != "")
& (subcontract_order.name == se.subcontracting_order) & (subcontract_order.name == se.subcontracting_order)
& (subcontract_order.status != "Closed")
) )
) )
) )