From db91a79d3189482dcbe9ed9154ba40eeb7597464 Mon Sep 17 00:00:00 2001 From: Sudharsanan11 Date: Sat, 25 Jul 2026 23:54:52 +0530 Subject: [PATCH] fix(subcontracting): release raw-material reservation when closing a subcontracting order the bin reserved-qty recalc filtered out closed purchase orders but not closed subcontracting orders, so closing a partially-received sco kept the reservation for the unreceived qty and left projected qty understated. apply the same closed-status filter to the subcontracting order path. --- erpnext/stock/doctype/bin/bin.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/erpnext/stock/doctype/bin/bin.py b/erpnext/stock/doctype/bin/bin.py index f5417439ded..b004975d2fe 100644 --- a/erpnext/stock/doctype/bin/bin.py +++ b/erpnext/stock/doctype/bin/bin.py @@ -164,11 +164,8 @@ class Bin(Document): & (subcontract_order.name == supplied_item.parent) & (subcontract_order.per_received < 100) & (supplied_item.reserve_warehouse == self.warehouse) - & ( - ((subcontract_order.status != "Closed") & (subcontract_order.docstatus == 1)) - if subcontract_doctype == "Purchase Order" - else (subcontract_order.docstatus == 1) - ) + & (subcontract_order.status != "Closed") + & (subcontract_order.docstatus == 1) ) reserved_qty_for_sub_contract = ( @@ -203,6 +200,7 @@ class Bin(Document): else ( (Coalesce(se.subcontracting_order, "") != "") & (subcontract_order.name == se.subcontracting_order) + & (subcontract_order.status != "Closed") ) ) )