nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-12 22:21:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(manufacturing): cover Work Order Stock report duplicate-item row count

Browse Source 
Add a regression test for the one-row-per-item invariant: a BOM that lists the
same raw item on two lines at different qty must still be counted once in the
report ("# Req'd Items" == 1). The test fails on the pre-fix multi-column GROUP
BY (which split the item into one row per distinct stock_qty -> 2) and passes
after the fix, on both MariaDB and Postgres.
This commit is contained in:
Mihir Kandoi
2026-06-22 01:05:01 +05:30
parent 7f6004bfd9
commit d65098fe24
1 changed files with 45 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
erpnext/manufacturing/report/work_order_stock_report/test_work_order_stock_report.py
View File

@@ -22,3 +22,48 @@ class TestWorkOrderStockReport(ERPNextTestSuite):
self.assertTrue(columns)
self.assertIn(wo.name, {row["work_order"] for row in data})
def test_item_listed_twice_in_bom_is_counted_once(self):
# A BOM may list the same raw item on multiple lines at different qty (validate_materials does
# not dedupe). get_item_list aggregates the qty columns and groups by item_code only, so the
# report stays one row per item — matching the original MariaDB output. The pre-fix multi-column
# GROUP BY split such an item into one row per distinct stock_qty, inflating "# Req'd Items".
from erpnext.manufacturing.doctype.production_plan.test_production_plan import make_bom
from erpnext.manufacturing.doctype.work_order.test_work_order import make_wo_order_test_record
from erpnext.manufacturing.report.work_order_stock_report.work_order_stock_report import execute
from erpnext.stock.doctype.item.test_item import make_item
fg_item = make_item("_Test WO Stock Dup FG", {"is_stock_item": 1}).name
rm_item = "_Test Item"
bom = make_bom(item=fg_item, raw_materials=[rm_item], rm_qty=1, currency="INR", do_not_save=True)
# a second line for the same raw item at a different qty -> a different stock_qty
first = bom.items[0]
bom.append(
"items",
{
"item_code": rm_item,
"qty": 2,
"uom": first.uom,
"stock_uom": first.stock_uom,
"rate": first.rate,
},
)
bom.insert(ignore_permissions=True)
bom.submit()
wo = make_wo_order_test_record(
production_item=fg_item,
bom_no=bom.name,
qty=1,
source_warehouse="_Test Warehouse - _TC",
skip_transfer=1,
)
columns, data = execute(frappe._dict(warehouse="_Test Warehouse - _TC"))
wo_rows = [row for row in data if row["work_order"] == wo.name]
self.assertTrue(wo_rows)
# the duplicated raw item must be counted once per work order item, not once per BOM line
for row in wo_rows:
self.assertEqual(row["req_items"], 1)