nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-08 15:42:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove unwanted serial numbers from fifo_queue (bp #27228)

Browse Source 
fifo_queue.remove(serial_no) causes shift in index of the list and thereby not looping through every object in the list.
This commit is contained in:
Dany Robert
2021-08-31 10:51:43 +05:30
committed by GitHub
parent dc76094a9f
commit cef6a8434a
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/stock/report/stock_ageing/stock_ageing.py
View File

@@ -175,9 +175,7 @@ def get_fifo_queue(filters, sle=None):
fifo_queue.append([d.actual_qty, d.posting_date]) fifo_queue.append([d.actual_qty, d.posting_date])
else: else:
if serial_no_list: if serial_no_list:
for serial_no in fifo_queue: fifo_queue[:] = [serial_no for serial_no in fifo_queue if serial_no[0] not in serial_no_list]
if serial_no[0] in serial_no_list:
fifo_queue.remove(serial_no)
else: else:
qty_to_pop = abs(d.actual_qty) qty_to_pop = abs(d.actual_qty)
while qty_to_pop: while qty_to_pop: