From cef6a8434a10f8a1f1ff4b959457f804fa757878 Mon Sep 17 00:00:00 2001 From: Dany Robert Date: Tue, 31 Aug 2021 10:51:43 +0530 Subject: [PATCH] fix: remove unwanted serial numbers from fifo_queue (bp #27228) fifo_queue.remove(serial_no) causes shift in index of the list and thereby not looping through every object in the list. --- erpnext/stock/report/stock_ageing/stock_ageing.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/erpnext/stock/report/stock_ageing/stock_ageing.py b/erpnext/stock/report/stock_ageing/stock_ageing.py index 4919f8b4c05..47345ce7f8d 100644 --- a/erpnext/stock/report/stock_ageing/stock_ageing.py +++ b/erpnext/stock/report/stock_ageing/stock_ageing.py @@ -175,9 +175,7 @@ def get_fifo_queue(filters, sle=None): fifo_queue.append([d.actual_qty, d.posting_date]) else: if serial_no_list: - for serial_no in fifo_queue: - if serial_no[0] in serial_no_list: - fifo_queue.remove(serial_no) + fifo_queue[:] = [serial_no for serial_no in fifo_queue if serial_no[0] not in serial_no_list] else: qty_to_pop = abs(d.actual_qty) while qty_to_pop: