nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-17 00:18:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(postgres): satisfy strict GROUP BY in Total Stock Summary report

Browse Source 
Wrap the non-aggregated, functionally-dependent column(s) in Max()/Min() (or add
them to GROUP BY) so the report's grouped query is valid under PostgreSQL's strict
GROUP BY. No behaviour change on MariaDB.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mihir Kandoi
2026-06-17 13:19:08 +05:30
parent 9096b4a9df
commit c124e90a89
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/stock/report/total_stock_summary/total_stock_summary.py
View File

@@ -4,7 +4,7 @@
import frappe
from frappe import _
from frappe.query_builder.functions import Sum
from frappe.query_builder.functions import Max, Sum
def execute(filters=None):
@@ -53,8 +53,9 @@ def get_total_stock(filters):
else:
query = query.select(wh.company).groupby(wh.company)
query = query.select(item.item_code, item.description, Sum(bin.actual_qty).as_("actual_qty")).groupby(
item.item_code
)
# description is constant per grouped item_code -> Max() keeps the GROUP BY valid on postgres
query = query.select(
item.item_code, Max(item.description).as_("description"), Sum(bin.actual_qty).as_("actual_qty")
).groupby(item.item_code)
return query.run()