nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-09 15:29:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #58909 from khushi8112/fix/posting-date-confirmation

Browse Source 
fix: read posting date confirmation setting from boot data
This commit is contained in:
Khushi Rawat
2026-09-09 12:50:41 +05:30
committed by GitHub
parent b2bdeaa672 bcade8f0ba
commit bdf124ab06
3 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/accounts/doctype/accounts_settings/accounts_settings.py
View File

@@ -222,6 +222,13 @@ class AccountsSettings(Document):
set_allow_on_submit_for_dimension_fields(doctypes)
@frappe.whitelist(methods=["POST"])
def get_posting_date_confirmation() -> int:
return cint(
frappe.db.get_single_value("Accounts Settings", "confirm_before_resetting_posting_date", cache=False)
)
def toggle_accounting_dimension_sections(hide):
accounting_dimension_doctypes = frappe.get_hooks("accounting_dimension_doctypes")
for doctype in accounting_dimension_doctypes:

6
erpnext/accounts/doctype/accounts_settings/test_accounts_settings.py
View File

@@ -1,9 +1,15 @@
import frappe
from erpnext.accounts.doctype.accounts_settings.accounts_settings import get_posting_date_confirmation
from erpnext.tests.utils import ERPNextTestSuite
class TestAccountsSettings(ERPNextTestSuite):
def test_posting_date_confirmation_uses_current_setting(self):
for enabled in (0, 1, 0):
frappe.db.set_single_value("Accounts Settings", "confirm_before_resetting_posting_date", enabled)
self.assertEqual(get_posting_date_confirmation(), enabled)
def test_stale_days(self):
cur_settings = frappe.get_doc("Accounts Settings", "Accounts Settings")
cur_settings.allow_stale = 0

6
erpnext/public/js/controllers/transaction.js
View File

@@ -1150,11 +1150,9 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
if (this.frm.doc.set_posting_time) return;
if (frappe.datetime.get_today() == this.frm.doc.posting_date) return;
let is_confirmation_reqd = await frappe.db.get_single_value(
"Accounts Settings",
"confirm_before_resetting_posting_date"
const is_confirmation_reqd = await frappe.xcall(
"erpnext.accounts.doctype.accounts_settings.accounts_settings.get_posting_date_confirmation"
);
if (!is_confirmation_reqd) return;
return new Promise((resolve, reject) => {