nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-14 09:23:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: coerce cost_allocation_per to float in BOM cost allocation

Browse Source
This commit is contained in:
Shllokkk
2026-09-10 18:53:39 +05:30
parent 1b51f8cbd6
commit bc2fa03730
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/manufacturing/doctype/bom/bom.py
View File

@@ -487,9 +487,10 @@ class BOM(WebsiteGenerator):
doc.set_status(save=True)
def set_fg_cost_allocation(self):
self.cost_allocation_per = flt(self.cost_allocation_per)
total_secondary_items_per = 0
for item in self.secondary_items:
total_secondary_items_per += item.cost_allocation_per
total_secondary_items_per += flt(item.cost_allocation_per)
if self.cost_allocation_per == 100 and total_secondary_items_per:
self.cost_allocation_per -= total_secondary_items_per
@@ -497,9 +498,9 @@ class BOM(WebsiteGenerator):
self.cost_allocation = self.raw_material_cost * (self.cost_allocation_per / 100)
def validate_total_cost_allocation(self):
total_cost_allocation_per = self.cost_allocation_per
total_cost_allocation_per = flt(self.cost_allocation_per)
for item in self.secondary_items:
total_cost_allocation_per += item.cost_allocation_per
total_cost_allocation_per += flt(item.cost_allocation_per)
if total_cost_allocation_per != 100:
frappe.throw(_("Cost allocation between finished goods and secondary items should equal 100%"))

2
erpnext/manufacturing/doctype/bom/services/costing.py
View File

@@ -268,7 +268,7 @@ class BOMCostingService:
for d in self.doc.get("secondary_items"):
if not d.is_legacy:
d.cost = flt(self.doc.raw_material_cost * (d.cost_allocation_per / 100), precision)
d.cost = flt(self.doc.raw_material_cost * (flt(d.cost_allocation_per) / 100), precision)
d.base_cost = flt(d.cost * self.doc.conversion_rate, precision)
total_sm_cost += d.cost