nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-30 07:08:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(stock): savepoint around expected duplicate barcode save (Postgres)

Browse Source 
The deliberate UniqueValidationError when re-adding a barcode aborts the
transaction on Postgres, so the next frappe.get_doc() failed with
InFailedSqlTransaction. Wrap the expected-failure save in a savepoint and roll
back to it. No-op on MariaDB.
This commit is contained in:
Mihir Kandoi
2026-06-21 15:29:36 +05:30
parent 72046d3688
commit b760b9d935
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/stock/doctype/item/test_item.py
View File

@@ -751,7 +751,9 @@ class TestItem(ERPNextTestSuite):
item_doc = frappe.get_doc("Item", item_code)
new_barcode = item_doc.append("barcodes")
new_barcode.update(barcode_properties_list[0])
frappe.db.savepoint("dup_barcode")
self.assertRaises(frappe.UniqueValidationError, item_doc.save)
frappe.db.rollback(save_point="dup_barcode") # preserve transaction in postgres
# Add invalid barcode - should cause InvalidBarcode
item_doc = frappe.get_doc("Item", item_code)