nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-13 22:51:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(postgres): satisfy strict GROUP BY in Process Loss Report report

Browse Source 
Wrap the non-aggregated, functionally-dependent column(s) in Max()/Min() (or add
them to GROUP BY) so the report's grouped query is valid under PostgreSQL's strict
GROUP BY. No behaviour change on MariaDB.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mihir Kandoi
2026-06-17 13:19:02 +05:30
parent 9ab8803fed
commit a3ec98a57c
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/manufacturing/report/process_loss_report/process_loss_report.py
View File

@@ -4,7 +4,7 @@
import frappe
from frappe import _
from frappe.query_builder.functions import Sum
from frappe.query_builder.functions import Max, Sum
Filters = frappe._dict
Row = frappe._dict
@@ -29,12 +29,14 @@ def get_data(filters: Filters) -> Data:
.inner_join(se)
.on(wo.name == se.work_order)
.select(
wo.name,
wo.status,
wo.production_item,
wo.produced_qty,
wo.process_loss_qty,
wo.qty.as_("qty_to_manufacture"),
# grouped by se.work_order (== wo.name); the work-order columns are constant per group ->
# Max() keeps the GROUP BY valid on postgres with the same value.
Max(wo.name).as_("name"),
Max(wo.status).as_("status"),
Max(wo.production_item).as_("production_item"),
Max(wo.produced_qty).as_("produced_qty"),
Max(wo.process_loss_qty).as_("process_loss_qty"),
Max(wo.qty).as_("qty_to_manufacture"),
Sum(se.total_incoming_value).as_("total_fg_value"),
Sum(se.total_outgoing_value).as_("total_rm_value"),
)