nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-21 14:09:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent duplicate task execution and timestamp error in transaction deletion (backport #55021) (#55025)

Browse Source 
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
fix: prevent duplicate task execution and timestamp error in transaction deletion (#55021)
This commit is contained in:
mergify[bot]
2026-05-18 17:55:05 +00:00
committed by GitHub
parent ff0533d085
commit 9857cc64d6
3 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
erpnext/setup/doctype/company/company.py
View File

@@ -1085,7 +1085,6 @@ def create_transaction_deletion_request(company):
tdr.reload() tdr.reload()
tdr.submit() tdr.submit()
tdr.start_deletion_tasks()
frappe.msgprint( frappe.msgprint(
_("Transaction Deletion Document {0} has been triggered for company {1}").format( _("Transaction Deletion Document {0} has been triggered for company {1}").format(

1
erpnext/setup/doctype/transaction_deletion_record/test_transaction_deletion_record.py
View File

@@ -396,7 +396,6 @@ def create_and_submit_transaction_deletion_doc(company):
tdr.process_in_single_transaction = True tdr.process_in_single_transaction = True
tdr.submit() tdr.submit()
tdr.start_deletion_tasks()
return tdr return tdr

9
erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.py
View File

@@ -736,10 +736,11 @@ class TransactionDeletionRecord(Document):
self.enqueue_task(task="Clear Notifications") self.enqueue_task(task="Clear Notifications")
return return
company_obj = frappe.get_doc("Company", self.company) frappe.db.set_value(
company_obj.total_monthly_sales = 0 "Company",
company_obj.sales_monthly_history = None self.company,
company_obj.save() {"total_monthly_sales": 0, "sales_monthly_history": None},
)
self.db_set("reset_company_default_values_status", "Completed") self.db_set("reset_company_default_values_status", "Completed")
self.enqueue_task(task="Clear Notifications") self.enqueue_task(task="Clear Notifications")