From 9857cc64d679221e8cf365e19500b31320eeecec Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Mon, 18 May 2026 17:55:05 +0000 Subject: [PATCH] fix: prevent duplicate task execution and timestamp error in transaction deletion (backport #55021) (#55025) Co-authored-by: Nabin Hait fix: prevent duplicate task execution and timestamp error in transaction deletion (#55021) --- erpnext/setup/doctype/company/company.py | 1 - .../test_transaction_deletion_record.py | 1 - .../transaction_deletion_record.py | 9 +++++---- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/erpnext/setup/doctype/company/company.py b/erpnext/setup/doctype/company/company.py index e4e9c24aeaf..dcd6da347c9 100644 --- a/erpnext/setup/doctype/company/company.py +++ b/erpnext/setup/doctype/company/company.py @@ -1085,7 +1085,6 @@ def create_transaction_deletion_request(company): tdr.reload() tdr.submit() - tdr.start_deletion_tasks() frappe.msgprint( _("Transaction Deletion Document {0} has been triggered for company {1}").format( diff --git a/erpnext/setup/doctype/transaction_deletion_record/test_transaction_deletion_record.py b/erpnext/setup/doctype/transaction_deletion_record/test_transaction_deletion_record.py index 5c716279b89..23683c3d6bb 100644 --- a/erpnext/setup/doctype/transaction_deletion_record/test_transaction_deletion_record.py +++ b/erpnext/setup/doctype/transaction_deletion_record/test_transaction_deletion_record.py @@ -396,7 +396,6 @@ def create_and_submit_transaction_deletion_doc(company): tdr.process_in_single_transaction = True tdr.submit() - tdr.start_deletion_tasks() return tdr diff --git a/erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.py b/erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.py index a76c37e2fee..e77316eb957 100644 --- a/erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.py +++ b/erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.py @@ -736,10 +736,11 @@ class TransactionDeletionRecord(Document): self.enqueue_task(task="Clear Notifications") return - company_obj = frappe.get_doc("Company", self.company) - company_obj.total_monthly_sales = 0 - company_obj.sales_monthly_history = None - company_obj.save() + frappe.db.set_value( + "Company", + self.company, + {"total_monthly_sales": 0, "sales_monthly_history": None}, + ) self.db_set("reset_company_default_values_status", "Completed") self.enqueue_task(task="Clear Notifications")