nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-15 23:48:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: check POS Payment Method rows when disabling a Mode of Payment

Browse Source
This commit is contained in:
Nabin Hait
2026-07-03 14:10:55 +05:30
parent 147e1539dc
commit 83801e032c
2 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/accounts/doctype/mode_of_payment/mode_of_payment.py
View File

@@ -53,7 +53,7 @@ class ModeofPayment(Document):
def validate_pos_mode_of_payment(self):
if not self.enabled:
pos_profiles = frappe.get_all(
"Sales Invoice Payment",
"POS Payment Method",
filters={"parenttype": "POS Profile", "mode_of_payment": self.name},
pluck="parent",
)

12
erpnext/accounts/doctype/mode_of_payment/test_mode_of_payment.py
View File

@@ -40,19 +40,15 @@ class TestModeofPayment(ERPNextTestSuite):
doc = self.make_mop(accounts=[(COMPANY, "Cash - _TC"), (COMPANY, "Debtors - _TC")])
self.assertRaises(frappe.ValidationError, doc.insert)
def test_disabling_mode_referenced_by_pos_profile_is_not_blocked(self):
# SUSPECTED BUG: validate_pos_mode_of_payment queries "Sales Invoice Payment"
# rows with parenttype "POS Profile", but a POS Profile's payments are stored
# as "POS Payment Method" rows. The filter never matches, so the guard is dead
# and a mode still referenced by a POS Profile disables without complaint.
# Locking the current (wrong) behaviour so a fix to the guard trips this test.
def test_disabling_mode_referenced_by_pos_profile_throws(self):
# the guard reads the POS Profile's "POS Payment Method" rows, so a mode still
# referenced by a POS Profile cannot be disabled
from erpnext.accounts.doctype.pos_profile.test_pos_profile import make_pos_profile
make_pos_profile() # its payments row references the "Cash" mode of payment
cash = frappe.get_doc("Mode of Payment", "Cash")
cash.enabled = 0
cash.save()
self.assertEqual(frappe.db.get_value("Mode of Payment", "Cash", "enabled"), 0)
self.assertRaises(frappe.ValidationError, cash.save)
def test_disabling_unreferenced_mode_succeeds(self):
doc = self.make_mop(accounts=[(COMPANY, "Cash - _TC")], enabled=0)