refactor(test): remove explicit call to master data setup

erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py

@@ -52,8 +52,6 @@ from erpnext.tests.utils import ERPNextTestSuite
 
 class TestSalesInvoice(ERPNextTestSuite):
 	def setUp(self):
-		self.make_employees()
-		self.make_sales_person()
 		self.load_test_records("Journal Entry")
 		self.load_test_records("Stock Entry")
 		self.load_test_records("Sales Invoice")

erpnext/controllers/tests/test_queries.py

@@ -99,7 +99,7 @@ class TestQueries(ERPNextTestSuite):
 			{
 				"user": user.name,
 				"doctype": "Employee",
-				"docname": self.employees[0].name,
+				"docname": "_Test Employee",
 				"is_default": 1,
 				"apply_to_all_doctypes": 1,
 				"applicable_doctypes": [],

erpnext/crm/doctype/lead/test_lead.py

@@ -17,9 +17,9 @@ class TestLead(ERPNextTestSuite):
 
 		frappe.delete_doc_if_exists("Customer", "_Test Lead")
 
-		customer = make_customer(self.leads[0].name)
+		customer = make_customer("_Test Lead")
 		self.assertEqual(customer.doctype, "Customer")
-		self.assertEqual(customer.lead_name, self.leads[0].name)
+		self.assertEqual(customer.lead_name, "_Test Lead")
 
 		customer.company = "_Test Company"
 		customer.customer_group = "_Test Customer Group"
@@ -43,9 +43,9 @@ class TestLead(ERPNextTestSuite):
 	def test_make_customer_from_organization(self):
 		from erpnext.crm.doctype.lead.lead import make_customer
 
-		customer = make_customer(self.leads[1].name)
+		customer = make_customer("_Test Lead 1")
 		self.assertEqual(customer.doctype, "Customer")
-		self.assertEqual(customer.lead_name, self.leads[1].name)
+		self.assertEqual(customer.lead_name, "_Test Lead 1")
 
 		customer.company = "_Test Company"
 		customer.customer_group = "_Test Customer Group"

erpnext/crm/doctype/opportunity/test_opportunity.py

@@ -14,12 +14,6 @@ from erpnext.tests.utils import ERPNextTestSuite
 
 
 class TestOpportunity(ERPNextTestSuite):
-	def setUp(self):
-		# Only first lead is required
-		# TODO: dynamically generate limited test records
-		self.make_leads()
-		self.make_opportunities()
-
 	@classmethod
 	def make_opportunities(cls):
 		records = [

erpnext/maintenance/doctype/maintenance_schedule/test_maintenance_schedule.py

@@ -156,7 +156,7 @@ class TestMaintenanceSchedule(ERPNextTestSuite):
 		self.assertFalse(ms.validate_items_table_change())
 		# After Save
 		ms.items[0].serial_no = "TEST001"
-		ms.items[0].sales_person = self.sales_person[0].name
+		ms.items[0].sales_person = "_Test Sales Person"
 		ms.items[0].no_of_visits = 2
 		self.assertTrue(ms.validate_items_table_change())
 		ms.save()

erpnext/manufacturing/doctype/job_card/test_job_card.py

@@ -29,7 +29,6 @@ from erpnext.tests.utils import ERPNextTestSuite
 class TestJobCard(ERPNextTestSuite):
 	def setUp(self):
 		self.load_test_records("BOM")
-		self.make_employees()  # used in job card time log
 		self.make_bom_for_jc_tests()
 		self.transfer_material_against: Literal["Work Order", "Job Card"] = "Work Order"
 		self.source_warehouse = None
@@ -187,7 +186,7 @@ class TestJobCard(ERPNextTestSuite):
 		jc1 = frappe.get_last_doc("Job Card", {"work_order": self.work_order.name})
 		jc2 = frappe.get_last_doc("Job Card", {"work_order": wo2.name})
 
-		employee = self.employees[0].name
+		employee = "_Test Employee"
 
 		jc1.append(
 			"time_logs",

erpnext/projects/doctype/activity_cost/test_activity_cost.py

@@ -10,17 +10,12 @@ from erpnext.tests.utils import ERPNextTestSuite
 
 
 class TestActivityCost(ERPNextTestSuite):
-	def setUp(self):
-		# TODO: only 1 employee is required
-		self.make_employees()
-		self.make_activity_type()
-
 	def test_duplication(self):
 		frappe.db.sql("delete from `tabActivity Cost`")
 		activity_cost1 = frappe.new_doc("Activity Cost")
 		activity_cost1.update(
 			{
-				"employee": self.employees[0].name,
+				"employee": "_Test Employee",
 				"employee_name": self.employees[0].first_name,
 				"activity_type": self.activity_type[1].name,
 				"billing_rate": 100,

erpnext/selling/doctype/party_specific_item/test_party_specific_item.py

@@ -18,8 +18,8 @@ def create_party_specific_item(**args):
 
 class TestPartySpecificItem(ERPNextTestSuite):
 	def test_item_query_for_customer(self):
-		customer = self.customer[0].name
+		customer = "_Test Customer With Template"
-		item = self.item[0].name
+		item = "_Test Item"
 
 		create_party_specific_item(
 			party_type="Customer",
@@ -34,8 +34,8 @@ class TestPartySpecificItem(ERPNextTestSuite):
 		self.assertTrue(item in flatten(items))
 
 	def test_item_query_for_supplier(self):
-		supplier = self.suppliers[0].name
+		supplier = "_Test Supplier With Template 1"
-		item = self.item_group[0].name
+		item = "_Test Item Group"
 
 		create_party_specific_item(
 			party_type="Supplier",

erpnext/stock/doctype/delivery_note/test_delivery_note.py

@@ -2613,7 +2613,7 @@ class TestDeliveryNote(ERPNextTestSuite):
 		self.assertEqual(dn.status, "To Bill")
 
 		si = make_sales_invoice(dn.name)
-		si.location = self.location[0].name
+		si.location = "Test Location"
 		si.submit()
 
 		dn_return = create_delivery_note(is_return=1, return_against=dn.name, qty=-2, do_not_submit=True)