nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-14 09:23:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(stock): rollback before marking Stock Closing Entry failed (Postgres)

Browse Source 
prepare_closing_stock_balance (background job) saves Stock Closing Balance rows + db_set status; on failure the except runs db_set('Failed')+log_error with no rollback, raising InFailedSqlTransaction on Postgres so the doc is never marked Failed and the job dies. Full frappe.db.rollback() before the handler's db_set. No-op on MariaDB.
This commit is contained in:
Mihir Kandoi
2026-06-29 22:45:19 +05:30
parent 44458b0ba5
commit 790560ebf8
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
erpnext/stock/doctype/stock_closing_entry/stock_closing_entry.py
View File

@@ -152,6 +152,7 @@ def prepare_closing_stock_balance(name):
doc.create_stock_closing_balance_entries() doc.create_stock_closing_balance_entries()
doc.db_set("status", "Completed") doc.db_set("status", "Completed")
except Exception: except Exception:
frappe.db.rollback()
doc.db_set("status", "Failed") doc.db_set("status", "Failed")
doc.log_error(title="Stock Closing Entry Failed") doc.log_error(title="Stock Closing Entry Failed")