refactor(email_digest): convert get_digest_msg from module function to instance method (#58193)

(cherry picked from commit 4cd8fbf1c0)

# Conflicts:
#	erpnext/setup/doctype/email_digest/email_digest.py
This commit is contained in:
Diptanil Saha
2026-08-15 19:40:14 +05:30
committed by Mergify
parent a5f4d3abeb
commit 77ff956556
2 changed files with 30 additions and 13 deletions

View File

@@ -5,23 +5,33 @@ frappe.ui.form.on("Email Digest", {
refresh: function (frm) {
if (!frm.is_new()) {
frm.add_custom_button(__("View Now"), function () {
frappe.call({
method: "erpnext.setup.doctype.email_digest.email_digest.get_digest_msg",
args: {
name: frm.doc.name,
},
callback: function (r) {
let d = new frappe.ui.Dialog({
title: __("Email Digest: {0}", [frm.doc.name]),
width: 800,
});
$(d.body).html(r.message);
d.show();
},
if (frm.is_dirty()) {
frappe.show_alert({
message: __("Save the Email Digest first.", "yellow"),
indicator: "yellow",
});
return;
}
frm.call("get_digest_msg").then((r) => {
let d = new frappe.ui.Dialog({
title: __("Email Digest: {0}", [frm.doc.name]),
width: 800,
});
$(d.body).html(r.message);
d.show();
});
});
frm.add_custom_button(__("Send Now"), function () {
if (frm.is_dirty()) {
frappe.show_alert({
message: __("Save the Email Digest first.", "yellow"),
indicator: "yellow",
});
return;
}
return frm.call("send", null, () => {
frappe.show_alert({ message: __("Message Sent"), indicator: "green" });
});

View File

@@ -885,6 +885,10 @@ class EmailDigest(Document):
t.amount = fmt_money(t.amount, 2, t.currency)
return purchase_order_list, purchase_order_items_overdue_list
@frappe.whitelist()
def get_digest_msg(self):
return self.get_msg_html()
def send():
now_date = now_datetime().date()
@@ -899,11 +903,14 @@ def send():
ed_obj.send()
<<<<<<< HEAD
@frappe.whitelist()
def get_digest_msg(name):
return frappe.get_doc("Email Digest", name).get_msg_html()
=======
>>>>>>> 4cd8fbf1c0 (refactor(email_digest): convert `get_digest_msg` from module function to instance method (#58193))
def get_incomes_expenses_for_period(account, from_date, to_date):
"""Get amounts for current and past periods"""