nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-09 23:39:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(stock): drop the forked data import runner

Browse Source 
The Data Import override copied the core background runner to swap one
line. Core now calls get_importer, so the subclass is used by the real
import and the copy can go. This also drops the enqueue_after_commit
that the copy had added on top of core.

Requires frappe#42648.
This commit is contained in:
Mihir Kandoi
2026-09-09 08:33:23 +05:30
parent 3acaa55db9
commit 766e51ae58
1 changed files with 0 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
erpnext/stock/serial_batch_import.py
View File

@@ -1,11 +1,7 @@
from copy import copy
import frappe
from frappe import _
from frappe.core.doctype.data_import.importer import Importer, Row
from frappe.utils.background_jobs import is_job_enqueued
from frappe.utils.scheduler import is_scheduler_inactive
from rq.timeouts import JobTimeoutException
from erpnext.stock.serial_batch_input import NUMBER_FIELDS
@@ -16,45 +12,6 @@ class SerialBatchDataImport:
return super().get_importer()
return SerialBatchImporter(self.reference_doctype, data_import=self, use_sniffer=self.use_csv_sniffer)
def start_import(self):
if not has_number_inputs(self.reference_doctype):
return super().start_import()
run_now = frappe.in_test or frappe.conf.developer_mode
if is_scheduler_inactive() and not run_now:
frappe.throw(_("Scheduler is inactive. Cannot import data."), title=_("Scheduler Inactive"))
job_id = f"data_import||{self.name}"
if not is_job_enqueued(job_id):
frappe.enqueue(
start_import,
queue="default",
timeout=10000,
event="data_import",
job_id=job_id,
data_import=self.name,
now=run_now,
enqueue_after_commit=True,
)
return True
def start_import(data_import):
data_import = frappe.get_doc("Data Import", data_import)
data_import.set_delimiters_flag()
try:
data_import.get_importer().import_data()
except JobTimeoutException:
frappe.db.rollback()
data_import.db_set("status", "Timed Out")
except Exception:
frappe.db.rollback()
data_import.db_set("status", "Error")
data_import.log_error("Data import failed")
finally:
frappe.flags.in_import = False
frappe.publish_realtime(
"data_import_refresh", {"data_import": data_import.name}, user=frappe.session.user
)
class SerialBatchImporter(Importer):
def __init__(self, *args, **kwargs):