nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-22 18:59:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(stock): drop zero-caller StockController delegators

Browse Source 
Re-audited the kept delegators for true external callers. Two had none:
- has_landed_cost_amount: no caller anywhere (the landed_cost_voucher.py free
  function is what the composers use) — pure dead delegator, removed.
- validate_internal_transfer: only StockController.validate() called it; inline that
  one hook to StockInternalTransferService(self).validate_internal_transfer() and
  remove the delegator.

All other kept delegators have real external/subclass/run_method callers and remain
as the stock extension contract.

Verified: ledger snapshots + DN/PR internal-transfer suites stay green.
This commit is contained in:
Nabin Hait
2026-06-05 12:46:09 +05:30
parent 78d5fbaca4
commit 6a064765d1
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
erpnext/controllers/stock_controller.py
View File

@@ -31,6 +31,7 @@ from erpnext.stock.exceptions import (
QualityInspectionRejectedError,
QualityInspectionRequiredError,
)
from erpnext.stock.services.internal_transfer import StockInternalTransferService
from erpnext.stock.stock_ledger import get_items_to_be_repost
@@ -50,7 +51,7 @@ class StockController(AccountsController):
self.clean_serial_nos()
self.validate_customer_provided_item()
self.set_rate_of_stock_uom()
self.validate_internal_transfer()
StockInternalTransferService(self).validate_internal_transfer()
self.validate_putaway_capacity()
self.reset_conversion_factor()
@@ -283,11 +284,6 @@ class StockController(AccountsController):
return set_landed_cost_voucher_amount(self)
def has_landed_cost_amount(self):
from erpnext.stock.doctype.landed_cost_voucher.landed_cost_voucher import has_landed_cost_amount
return has_landed_cost_amount(self)
def get_item_account_wise_lcv_entries(self):
from erpnext.stock.doctype.landed_cost_voucher.landed_cost_voucher import (
get_item_account_wise_lcv_entries,
@@ -390,11 +386,6 @@ class StockController(AccountsController):
for d in self.get("items"):
d.stock_uom_rate = d.rate / (d.conversion_factor or 1)
def validate_internal_transfer(self):
from erpnext.stock.services.internal_transfer import StockInternalTransferService
return StockInternalTransferService(self).validate_internal_transfer()
def validate_putaway_capacity(self):
from erpnext.stock.doctype.putaway_rule.putaway_rule import validate_putaway_capacity