nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-04-28 19:18:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: get_students not respecting the program

Browse Source 
The get_students function is not taking into account the program for which the fee needs to be created. If a student is enrolled for multiple programs then the fee schedule pull up the wrong count of students.
This commit is contained in:
Govind S Menokee
2020-02-11 11:23:16 +05:30
committed by GitHub
parent 90a46acc0d
commit 57d33f9ce6
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/education/doctype/fee_schedule/fee_schedule.py
View File

@@ -123,9 +123,11 @@ def get_students(student_group, academic_year, academic_term=None, student_categ
students = frappe.db.sql("""
select pe.student, pe.student_name, pe.program, pe.student_batch_name
from `tabStudent Group Student` sgs, `tabProgram Enrollment` pe
from `tabStudent Group Student` sgs, `tabProgram Enrollment` pe, `tabStudent Group` sg
where
pe.student = sgs.student and pe.academic_year = %s
and sg.program = pe.program
and sg.name = sgs.parent
and sgs.parent = %s and sgs.active = 1
{conditions}
""".format(conditions=conditions), (academic_year, student_group), as_dict=1)