nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-17 02:26:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: rewrite user-facing JS messages in Manufacturing module

Browse Source 
Conservative cleanup of frappe.throw/msgprint messages per the message style
guide; meaning, severity, and .format() arguments are unchanged:

- index bare {} placeholders as {0}/{1}/... so translators can reorder
- move f-strings / .format() / concatenation out of _() (they break gettext
  extraction and never translate)
- wrap translatable dynamic values (DocType/Select labels) in _()
- fix grammar and colloquialisms
- drop no-op _() wrapping runtime-built strings

Part of #53976.
This commit is contained in:
Mihir Kandoi
2026-06-25 17:26:54 +05:30
parent b0887e03fe
commit 51c4fc9dcc
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/manufacturing/doctype/bom_update_tool/bom_update_tool.js
View File

@@ -78,7 +78,7 @@ frappe.ui.form.on("BOM Update Tool", {
confirm_job_start: (frm, log_data) => { confirm_job_start: (frm, log_data) => {
let log_link = frappe.utils.get_form_link("BOM Update Log", log_data.name, true); let log_link = frappe.utils.get_form_link("BOM Update Log", log_data.name, true);
frappe.msgprint({ frappe.msgprint({
message: __("BOM Updation is queued and may take a few minutes. Check {0} for progress.", [ message: __("BOM update is queued and may take a few minutes. Check {0} for progress.", [
log_link, log_link,
]), ]),
title: __("BOM Update Initiated"), title: __("BOM Update Initiated"),

4
erpnext/manufacturing/doctype/work_order/work_order.js
View File

@@ -389,7 +389,7 @@ frappe.ui.form.on("Work Order", {
function () { function () {
const selected_rows = dialog.fields_dict["operations"].grid.get_selected_children(); const selected_rows = dialog.fields_dict["operations"].grid.get_selected_children();
if (selected_rows.length == 0) { if (selected_rows.length == 0) {
frappe.msgprint(__("Please select atleast one operation to create Job Card")); frappe.msgprint(__("Please select at least one operation to create Job Card"));
return; return;
} }
frappe.call({ frappe.call({
@@ -760,7 +760,7 @@ erpnext.work_order = {
frm.add_custom_button( frm.add_custom_button(
__("Close"), __("Close"),
function () { function () {
frappe.confirm(__("Once the Work Order is Closed. It can't be resumed."), () => { frappe.confirm(__("Once the Work Order is Closed, it cannot be resumed."), () => {
erpnext.work_order.change_work_order_status(frm, "Closed"); erpnext.work_order.change_work_order_status(frm, "Closed");
}); });
}, },