nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-17 16:38:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(manufacturing): fall back to item group defaults for work order warehouses (#58231)

Browse Source
This commit is contained in:
Pandiyan P
2026-08-17 13:36:01 +05:30
committed by GitHub
parent 2f82e0dd36
commit 4dc0b2ea52
2 changed files with 31 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
erpnext/manufacturing/doctype/work_order/services/required_items.py
View File

@@ -24,12 +24,14 @@ from erpnext.manufacturing.doctype.work_order.services.reservation import (
get_row_wise_serial_batch,
)
from erpnext.manufacturing.doctype.work_order.services.status import StatusService
from erpnext.setup.doctype.item_group.item_group import get_item_group_defaults
from erpnext.stock.utils import get_bin, get_latest_stock_qty
class RequiredItemsService:
def __init__(self, doc):
self.doc = doc
self._item_group_warehouses = {}
def update_required_items(self):
"""
@@ -116,7 +118,21 @@ class RequiredItemsService:
def _item_source_warehouse(self, item, reset_source_warehouse):
if reset_source_warehouse:
return self.doc.source_warehouse
return self.doc.source_warehouse or item.source_warehouse or item.default_warehouse
return (
self.doc.source_warehouse
or item.source_warehouse
or item.default_warehouse
or self._item_group_warehouse(item)
)
def _item_group_warehouse(self, item):
# components of a bom commonly share a group, look it up once for all of them
if item.item_group not in self._item_group_warehouses:
self._item_group_warehouses[item.item_group] = get_item_group_defaults(
item.item_code, self.doc.company
).get("default_warehouse")
return self._item_group_warehouses[item.item_group]
def _required_item_row(self, item, operation, source_warehouse):
return {

16
erpnext/manufacturing/doctype/work_order/work_order.py
View File

@@ -60,8 +60,9 @@ from erpnext.manufacturing.doctype.work_order.services.reservation import (
from erpnext.manufacturing.doctype.work_order.services.status import (
StatusService,
)
from erpnext.setup.doctype.item_group.item_group import get_item_group_defaults
from erpnext.stock.doctype.batch.batch import make_batch
from erpnext.stock.doctype.item.item import validate_end_of_life
from erpnext.stock.doctype.item.item import get_item_defaults, validate_end_of_life
from erpnext.stock.doctype.serial_no.serial_no import get_available_serial_nos
from erpnext.stock.utils import validate_warehouse_company
from erpnext.utilities.transaction_base import validate_uom_is_integer
@@ -568,7 +569,18 @@ class WorkOrder(Document):
if not self.wip_warehouse and not self.skip_transfer:
self.wip_warehouse = frappe.get_cached_value("Company", self.company, "default_wip_warehouse")
if not self.fg_warehouse:
self.fg_warehouse = frappe.get_cached_value("Company", self.company, "default_fg_warehouse")
self.fg_warehouse = (
frappe.get_cached_value("Company", self.company, "default_fg_warehouse")
or self.get_production_item_warehouse()
)
def get_production_item_warehouse(self):
if not self.production_item:
return None
return get_item_defaults(self.production_item, self.company).get(
"default_warehouse"
) or get_item_group_defaults(self.production_item, self.company).get("default_warehouse")
def check_wip_warehouse_skip(self):
if self.skip_transfer and not self.from_wip_warehouse: