nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-13 22:51:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(stock): convert packing slip item search to qb.get_query

Browse Source 
Replace the raw SELECT with get_match_cond in item_details with
frappe.qb.get_query(ignore_permissions=False) plus a Delivery Note Item
subquery; get_query applies the permission match conditions. Same result on
MariaDB; valid under Postgres.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mihir Kandoi
2026-06-19 22:11:44 +05:30
parent f9732efb23
commit 48bbf66422
1 changed files with 19 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
erpnext/stock/doctype/packing_slip/packing_slip.py
View File

@@ -207,13 +207,24 @@ class PackingSlip(StatusUpdater):
@frappe.whitelist()
@frappe.validate_and_sanitize_search_inputs
def item_details(doctype: str, txt: str, searchfield: str, start: int, page_len: int, filters: dict):
from erpnext.controllers.queries import get_match_cond
item = frappe.qb.DocType("Item")
dn_item = frappe.qb.DocType("Delivery Note Item")
delivery_note = (filters or {}).get("delivery_note")
return frappe.db.sql(
"""select name, item_name, description from `tabItem`
where name in ( select item_code FROM `tabDelivery Note Item`
where parent= {})
and {} like "{}" {}
limit {} offset {} """.format("%s", searchfield, "%s", get_match_cond(doctype), "%s", "%s"),
((filters or {}).get("delivery_note"), "%%%s%%" % txt, page_len, start),
query = frappe.qb.get_query(
"Item",
fields=["name", "item_name", "description"],
ignore_permissions=False,
)
return (
query.where(
item.name.isin(
frappe.qb.from_(dn_item).select(dn_item.item_code).where(dn_item.parent == delivery_note)
)
& item[searchfield].like(f"%{txt}%")
)
.limit(page_len)
.offset(start)
.run()
)