nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-03 13:38:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): better setup for loyalty point and POS Invoice

Browse Source
This commit is contained in:
ruthra kumar
2025-11-15 15:00:48 +05:30
parent 36e578e848
commit 478473a295
4 changed files with 155 additions and 104 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/accounts/doctype/loyalty_point_entry/test_loyalty_point_entry.py
View File

@@ -5,7 +5,6 @@ import unittest
import frappe
from frappe.utils import today
from erpnext.accounts.doctype.loyalty_program.test_loyalty_program import create_records
from erpnext.accounts.doctype.sales_invoice.test_sales_invoice import create_sales_invoice
from erpnext.tests.utils import ERPNextTestSuite
@@ -15,7 +14,6 @@ class TestLoyaltyPointEntry(ERPNextTestSuite):
def setUpClass(cls):
super().setUpClass()
# Create test records
create_records()
cls.loyalty_program_name = "Test Single Loyalty"
cls.customer_name = "Test Loyalty Customer"
customer = frappe.get_doc("Customer", cls.customer_name)

99
erpnext/accounts/doctype/loyalty_program/test_loyalty_program.py
View File

@@ -14,12 +14,6 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestLoyaltyProgram(ERPNextTestSuite):
@classmethod
def setUpClass(cls):
super().setUpClass()
# create relevant item, customer, loyalty program, etc
create_records()
def test_loyalty_points_earned_single_tier(self):
frappe.db.set_value("Customer", "Test Loyalty Customer", "loyalty_program", "Test Single Loyalty")
# create a new sales invoice
@@ -323,96 +317,3 @@ def create_sales_invoice_record(qty=1):
],
}
)
def create_records():
# create a new loyalty Account
if not frappe.db.exists("Account", "Loyalty - _TC"):
frappe.get_doc(
{
"doctype": "Account",
"account_name": "Loyalty",
"parent_account": "Direct Expenses - _TC",
"company": "_Test Company",
"is_group": 0,
"account_type": "Expense Account",
}
).insert()
# create a new loyalty program Single tier
if not frappe.db.exists("Loyalty Program", "Test Single Loyalty"):
frappe.get_doc(
{
"doctype": "Loyalty Program",
"loyalty_program_name": "Test Single Loyalty",
"auto_opt_in": 1,
"from_date": today(),
"loyalty_program_type": "Single Tier Program",
"conversion_factor": 1,
"expiry_duration": 10,
"company": "_Test Company",
"cost_center": "Main - _TC",
"expense_account": "Loyalty - _TC",
"collection_rules": [{"tier_name": "Bronce", "collection_factor": 1000, "min_spent": 0}],
}
).insert()
# create a new customer
if not frappe.db.exists("Customer", "Test Loyalty Customer"):
frappe.get_doc(
{
"customer_group": "_Test Customer Group",
"customer_name": "Test Loyalty Customer",
"customer_type": "Individual",
"doctype": "Customer",
"territory": "_Test Territory",
}
).insert()
# create a new loyalty program Multiple tier
if not frappe.db.exists("Loyalty Program", "Test Multiple Loyalty"):
frappe.get_doc(
{
"doctype": "Loyalty Program",
"loyalty_program_name": "Test Multiple Loyalty",
"auto_opt_in": 1,
"from_date": today(),
"loyalty_program_type": "Multiple Tier Program",
"conversion_factor": 1,
"expiry_duration": 10,
"company": "_Test Company",
"cost_center": "Main - _TC",
"expense_account": "Loyalty - _TC",
"collection_rules": [
{"tier_name": "Bronze", "collection_factor": 1000, "min_spent": 0},
{"tier_name": "Silver", "collection_factor": 1000, "min_spent": 10000},
{"tier_name": "Gold", "collection_factor": 1000, "min_spent": 19000},
],
}
).insert()
# create an item
if not frappe.db.exists("Item", "Loyal Item"):
frappe.get_doc(
{
"doctype": "Item",
"item_code": "Loyal Item",
"item_name": "Loyal Item",
"item_group": "All Item Groups",
"company": "_Test Company",
"is_stock_item": 1,
"opening_stock": 100,
"valuation_rate": 10000,
}
).insert()
# create item price
if not frappe.db.exists("Item Price", {"price_list": "Standard Selling", "item_code": "Loyal Item"}):
frappe.get_doc(
{
"doctype": "Item Price",
"price_list": "Standard Selling",
"item_code": "Loyal Item",
"price_list_rate": 10000,
}
).insert()

2
erpnext/accounts/doctype/pos_invoice/test_pos_invoice.py
View File

@@ -640,9 +640,7 @@ class TestPOSInvoice(ERPNextTestSuite):
from erpnext.accounts.doctype.loyalty_program.loyalty_program import (
get_loyalty_program_details_with_points,
)
from erpnext.accounts.doctype.loyalty_program.test_loyalty_program import create_records
create_records()
frappe.db.set_value("Customer", "Test Loyalty Customer", "loyalty_program", "Test Single Loyalty")
before_lp_details = get_loyalty_program_details_with_points(
"Test Loyalty Customer", company="_Test Company", loyalty_program="Test Single Loyalty"

156
erpnext/tests/utils.py
View File

@@ -9,7 +9,7 @@ import frappe
from frappe import _
from frappe.core.doctype.report.report import get_report_module_dotted_path
from frappe.tests.utils import load_test_records_for
from frappe.utils import now_datetime
from frappe.utils import now_datetime, today
ReportFilters = dict[str, Any]
ReportName = NewType("ReportName", str)
@@ -235,6 +235,8 @@ class ERPNextTestSuite(unittest.TestCase):
cls._make_item()
cls.make_location()
cls.make_price_list()
cls.make_item_price()
cls.make_loyalty_program()
cls.make_shareholder()
cls.make_sales_taxes_template()
cls.update_selling_settings()
@@ -2136,6 +2138,17 @@ class ERPNextTestSuite(unittest.TestCase):
"asset_naming_series": "ABC.###",
"stock_uom": "_Test UOM",
},
{
"doctype": "Item",
"item_code": "Loyal Item",
"item_name": "Loyal Item",
"item_group": "All Item Groups",
"company": "_Test Company",
"is_stock_item": 1,
"opening_stock": 100,
"valuation_rate": 10000,
"stock_uom": "_Test UOM",
},
]
cls.item = []
for x in records:
@@ -2190,6 +2203,8 @@ class ERPNextTestSuite(unittest.TestCase):
["_Test Payable", "Current Liabilities", 0, "Payable", None],
["_Test Receivable USD", "Current Assets", 0, "Receivable", "USD"],
["_Test Payable USD", "Current Liabilities", 0, "Payable", "USD"],
# Loyalty Account
["Loyalty", "Direct Expenses", 0, "Expense Account", None],
]
cls.test_accounts = []
@@ -2280,6 +2295,13 @@ class ERPNextTestSuite(unittest.TestCase):
"territory": "_Test Territory",
"tax_category": "_Test Tax Category 1",
},
{
"customer_group": "_Test Customer Group",
"customer_name": "Test Loyalty Customer",
"customer_type": "Individual",
"doctype": "Customer",
"territory": "_Test Territory",
},
]
cls.customer = []
for x in records:
@@ -2632,6 +2654,138 @@ class ERPNextTestSuite(unittest.TestCase):
frappe.get_doc("Activity Type", {"activity_type": x.get("activity_type")})
)
@classmethod
def make_loyalty_program(cls):
records = [
{
"doctype": "Loyalty Program",
"loyalty_program_name": "Test Single Loyalty",
"auto_opt_in": 1,
"from_date": today(),
"loyalty_program_type": "Single Tier Program",
"conversion_factor": 1,
"expiry_duration": 10,
"company": "_Test Company",
"cost_center": "Main - _TC",
"expense_account": "Loyalty - _TC",
"collection_rules": [{"tier_name": "Bronce", "collection_factor": 1000, "min_spent": 0}],
},
{
"doctype": "Loyalty Program",
"loyalty_program_name": "Test Multiple Loyalty",
"auto_opt_in": 1,
"from_date": today(),
"loyalty_program_type": "Multiple Tier Program",
"conversion_factor": 1,
"expiry_duration": 10,
"company": "_Test Company",
"cost_center": "Main - _TC",
"expense_account": "Loyalty - _TC",
"collection_rules": [
{"tier_name": "Bronze", "collection_factor": 1000, "min_spent": 0},
{"tier_name": "Silver", "collection_factor": 1000, "min_spent": 10000},
{"tier_name": "Gold", "collection_factor": 1000, "min_spent": 19000},
],
},
]
cls.loyalty_program = []
for x in records:
if not frappe.db.exists(
"Loyalty Program", {"loyalty_program_name": x.get("loyalty_program_name")}
):
cls.loyalty_program.append(frappe.get_doc(x).insert())
else:
cls.loyalty_program.append(
frappe.get_doc("Loyalty Program", {"loyalty_program_name": x.get("loyalty_program_name")})
)
@classmethod
def make_item_price(cls):
records = [
{
"doctype": "Item Price",
"item_code": "_Test Item",
"price_list": "_Test Price List",
"price_list_rate": 100,
"valid_from": "2017-04-18",
"valid_upto": "2017-04-26",
},
{
"doctype": "Item Price",
"item_code": "_Test Item",
"price_list": "_Test Price List Rest of the World",
"price_list_rate": 10,
},
{
"doctype": "Item Price",
"item_code": "_Test Item 2",
"price_list": "_Test Price List Rest of the World",
"price_list_rate": 20,
"valid_from": "2017-04-18",
"valid_upto": "2017-04-26",
"customer": "_Test Customer",
"uom": "_Test UOM",
},
{
"doctype": "Item Price",
"item_code": "_Test Item Home Desktop 100",
"price_list": "_Test Price List",
"price_list_rate": 1000,
"valid_from": "2017-04-10",
"valid_upto": "2017-04-17",
},
{
"doctype": "Item Price",
"item_code": "_Test Item Home Desktop Manufactured",
"price_list": "_Test Price List",
"price_list_rate": 1000,
"valid_from": "2017-04-10",
"valid_upto": "2017-04-17",
},
{
"doctype": "Item Price",
"item_code": "_Test Item",
"price_list": "_Test Buying Price List",
"price_list_rate": 100,
"supplier": "_Test Supplier",
},
{
"doctype": "Item Price",
"item_code": "_Test Item",
"price_list": "_Test Selling Price List",
"price_list_rate": 200,
"customer": "_Test Customer",
},
{
"doctype": "Item Price",
"price_list": _("Standard Selling"),
"item_code": "Loyal Item",
"price_list_rate": 10000,
},
]
cls.item_price = []
for x in records:
if not frappe.db.exists(
"Item Price",
{
"item_code": x.get("item_code"),
"price_list": x.get("price_list"),
"price_list_rate": x.get("price_list_rate"),
},
):
cls.item_price.append(frappe.get_doc(x).insert())
else:
cls.item_price.append(
frappe.get_doc(
"Item Price",
{
"item_code": x.get("item_code"),
"price_list": x.get("price_list"),
"price_list_rate": x.get("price_list_rate"),
},
)
)
@contextmanager
def set_user(self, user: str):
try: