nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-05 06:28:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #43818 from frappe/mergify/bp/version-15/pr-43817

Browse Source 
fix: Unnecessary validation for non-deferred sales invoices (#43816)
This commit is contained in:
Deepesh Garg
2024-10-24 13:51:15 +05:30
committed by GitHub
parent 188645bfd6 a79bc4d35a
commit 3df68e462f
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/accounts/doctype/sales_invoice/sales_invoice.py
View File

@@ -297,8 +297,11 @@ class SalesInvoice(SellingController):
self.update_current_stock()
self.validate_delivery_note()
is_deferred_invoice = any(d.get("enable_deferred_revenue") for d in self.get("items"))
# validate service stop date to lie in between start and end date
validate_service_stop_date(self)
if is_deferred_invoice:
validate_service_stop_date(self)
if not self.is_opening:
self.is_opening = "No"