nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-17 08:28:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use get_root_of for Item Group root resolution

Browse Source 
Replaces the hand-rolled parentless-group query from #57390 with the
framework helper, matching sibling tree doctypes like Customer Group.
This commit is contained in:
Mihir Kandoi
2026-07-23 14:48:37 +05:30
parent da8bf368da
commit 3b3e7b5ea4
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/setup/doctype/item_group/item_group.py
View File

@@ -4,7 +4,7 @@
import frappe
from frappe import _
from frappe.utils.nestedset import NestedSet
from frappe.utils.nestedset import NestedSet, get_root_of
class ItemGroup(NestedSet):
@@ -32,9 +32,7 @@ class ItemGroup(NestedSet):
def validate(self):
if not self.parent_item_group and not frappe.in_test:
root = frappe.db.get_value(
"Item Group", {"parent_item_group": ("is", "not set"), "is_group": 1}, order_by="lft asc"
)
root = get_root_of(self.doctype)
if root and root != self.name:
self.parent_item_group = root
self.validate_item_group_defaults()