nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-05 05:09:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #55375 from loicdokos/refactor/sales_invoice-get_mode_of_payment_info

Browse Source 
refactor(sales_invoice): replace sql with qb in get_mode_of_payment_info
This commit is contained in:
Mihir Kandoi
2026-06-03 11:27:31 +05:30
committed by GitHub
parent 36dc196a1d 7ee7c4253b
commit 3b2f2168d0
1 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
erpnext/accounts/doctype/sales_invoice/sales_invoice.py
View File

@@ -3182,15 +3182,23 @@ def get_mode_of_payments_info(mode_of_payments, company):
def get_mode_of_payment_info(mode_of_payment, company):
return frappe.db.sql(
"""
select mpa.default_account, mpa.parent, mp.type as type
from `tabMode of Payment Account` mpa,`tabMode of Payment` mp
where mpa.parent = mp.name and mpa.company = %s and mp.enabled = 1 and mp.name = %s""",
(company, mode_of_payment),
as_dict=1,
ModeOfPaymentAccount = frappe.qb.DocType("Mode of Payment Account")
ModeOfPayment = frappe.qb.DocType("Mode of Payment")
query = (
frappe.qb.from_(ModeOfPayment)
.join(ModeOfPaymentAccount)
.on(ModeOfPaymentAccount.parent == ModeOfPayment.name)
.select(
ModeOfPaymentAccount.default_account, ModeOfPaymentAccount.parent, ModeOfPayment.type.as_("type")
)
.where(ModeOfPaymentAccount.company == company)
.where(ModeOfPayment.enabled == 1)
.where(ModeOfPayment.name == mode_of_payment)
)
return query.run(as_dict=1)
@frappe.whitelist()
def create_dunning(