nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-17 18:45:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #55274 from yash14023/fix/debit-note-prevent-update-stock

Browse Source 
fix(accounts): prevent update_stock on Debit Notes
This commit is contained in:
Nabin Hait
2026-06-10 10:44:20 +05:30
committed by GitHub
parent dfc824ded6 9084570d18
commit 3ad32f4030
3 changed files with 29 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/accounts/doctype/sales_invoice/sales_invoice.js
View File

@@ -586,6 +586,8 @@ erpnext.accounts.SalesInvoiceController = class SalesInvoiceController extends (
set_dynamic_labels() { set_dynamic_labels() {
super.set_dynamic_labels(); super.set_dynamic_labels();
this.frm.events.hide_fields(this.frm); this.frm.events.hide_fields(this.frm);
const hide_update_stock = cint(this.frm.doc.is_debit_note) || cint(this.frm.doc.has_subcontracted);
this.frm.set_df_property("update_stock", "hidden", hide_update_stock);
} }
items_on_form_rendered() { items_on_form_rendered() {
@@ -1174,13 +1176,20 @@ frappe.ui.form.on("Sales Invoice", {
); );
}, },
is_debit_note: function (frm) {
if (frm.doc.is_debit_note) {
frm.set_value("update_stock", 0);
}
// visibility handled by set_dynamic_labels()
frm.cscript.set_dynamic_labels();
},
refresh: function (frm) { refresh: function (frm) {
if (frm.doc.is_debit_note) { if (frm.doc.is_debit_note) {
frm.set_df_property("return_against", "label", __("Adjustment Against")); frm.set_df_property("return_against", "label", __("Adjustment Against"));
} }
frm.set_df_property("update_stock", "read_only", frm.doc.has_subcontracted); frm.set_df_property("update_stock", "read_only", frm.doc.has_subcontracted);
frm.toggle_display("update_stock", !frm.doc.has_subcontracted);
}, },
}); });

12
erpnext/accounts/doctype/sales_invoice/sales_invoice.py
View File

@@ -304,6 +304,7 @@ class SalesInvoice(SellingController):
self.validate_uom_is_integer("uom", "qty") self.validate_uom_is_integer("uom", "qty")
self.check_sales_order_on_hold_or_close("sales_order") self.check_sales_order_on_hold_or_close("sales_order")
self.validate_debit_to_acc() self.validate_debit_to_acc()
self.validate_debit_note_with_update_stock()
self.clear_unallocated_advances("Sales Invoice Advance", "advances") self.clear_unallocated_advances("Sales Invoice Advance", "advances")
FixedAssetService(self).validate_fixed_asset() FixedAssetService(self).validate_fixed_asset()
FixedAssetService(self).set_income_account_for_fixed_assets() FixedAssetService(self).set_income_account_for_fixed_assets()
@@ -960,6 +961,17 @@ class SalesInvoice(SellingController):
if flt(self.change_amount) and not self.account_for_change_amount: if flt(self.change_amount) and not self.account_for_change_amount:
msgprint(_("Please enter Account for Change Amount"), raise_exception=1) msgprint(_("Please enter Account for Change Amount"), raise_exception=1)
def validate_debit_note_with_update_stock(self):
"""Prevent stock update when Sales Invoice is marked as Debit Note."""
if self.is_debit_note and cint(self.update_stock):
frappe.throw(
_(
"You cannot update stock for a Debit Note. A Debit Note is a financial "
"document that should not affect inventory. Please disable 'Update Stock'."
),
title=_("Invalid Configuration"),
)
def validate_dropship_item(self): def validate_dropship_item(self):
"""If items are drop shipped, stock cannot be updated.""" """If items are drop shipped, stock cannot be updated."""
if not cint(self.update_stock): if not cint(self.update_stock):

7
erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py
View File

@@ -5213,6 +5213,13 @@ class TestSalesInvoice(ERPNextTestSuite):
frappe.db.set_value("Company", "_Test Company 1", "cost_center", cost_center) frappe.db.set_value("Company", "_Test Company 1", "cost_center", cost_center)
def test_debit_note_with_update_stock_validation(self):
"""Test that saving a Debit Note with Update Stock enabled raises ValidationError."""
si = create_sales_invoice(do_not_save=True)
si.is_debit_note = 1
si.update_stock = 1
self.assertRaises(frappe.ValidationError, si.save)
def make_item_for_si(item_code, properties=None): def make_item_for_si(item_code, properties=None):
from erpnext.stock.doctype.item.test_item import make_item from erpnext.stock.doctype.item.test_item import make_item