nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-15 23:48:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #57115 from mihir-kandoi/fix/supplier-scorecard-month-end-idempotency

Browse Source 
fix: duplicate scorecard period when supplier is created on a month end
This commit is contained in:
Mihir Kandoi
2026-07-14 10:55:59 +05:30
committed by GitHub
parent 39b5c6ba2a 3aafda331b
commit 336970aa5a
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/buying/doctype/supplier_scorecard/supplier_scorecard.py
View File

@@ -201,14 +201,16 @@ def make_all_scorecards(docname: str):
while (start_date < todays) and (end_date <= todays):
# check to make sure there is no scorecard period already created
# (inclusive bounds: a single-day period — supplier created on a month's
# last day — must match its own window, else it is re-created every run)
scorecards = frappe.get_all(
"Supplier Scorecard Period",
fields=["name"],
filters={
"scorecard": docname,
"docstatus": 1,
"start_date": ["<", end_date],
"end_date": [">", start_date],
"start_date": ["<=", end_date],
"end_date": [">=", start_date],
},
order_by="end_date desc",
)