nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-16 16:08:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: scope date range, reload invoice, strengthen total-row check

Browse Source
This commit is contained in:
Nabin Hait
2026-07-02 17:12:58 +05:30
parent 55646667be
commit 2bab709ac4
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/selling/report/sales_person_commission_summary/test_sales_person_commission_summary.py
View File

@@ -31,11 +31,20 @@ class TestSalesPersonCommissionSummary(ERPNextTestSuite):
)
si.insert()
si.submit()
si.reload() # reflect any values recomputed on submit
return si
def run_report(self, **extra):
filters = frappe._dict(
{"company": "_Test Company", "doc_type": "Sales Invoice", "sales_person": self.sales_person}
{
"company": "_Test Company",
"doc_type": "Sales Invoice",
"sales_person": self.sales_person,
# scope to this test's posting date so the query isn't unbounded over
# every invoice for the shared sales person
"from_date": "2026-06-01",
"to_date": "2026-06-01",
}
)
filters.update(extra)
return execute(filters)[1]
@@ -64,8 +73,9 @@ class TestSalesPersonCommissionSummary(ERPNextTestSuite):
def test_appends_total_row(self):
self.make_invoice_with_commission()
rows = self.run_report()
# the report appends a blank total row after the data rows
self.assertTrue(rows)
# the report appends a blank total row after one or more real data rows
self.assertGreaterEqual(len(rows), 2)
self.assertTrue(any(r[0] for r in rows[:-1]), "expected real data rows before the total row")
self.assertEqual(rows[-1], [""] * len(rows[0]))
def test_sales_person_filter_scopes_rows(self):