nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-20 09:49:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: escape item code and UOM in the supplier dialog errors

Browse Source 
Desk renders a client side message as HTML, so an Item or UOM whose name holds
markup ran as markup in the buyer's session.
This commit is contained in:
Mihir Kandoi
2026-08-01 09:11:37 +05:30
parent 3856eaa35e
commit 21c6d10ad3
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
erpnext/stock/doctype/material_request/material_request.js
View File

@@ -518,23 +518,30 @@ frappe.ui.form.on("Material Request", {
frappe.throw(__("Select at least one Item"));
}
const item_link = (row) =>
frappe.utils.get_form_link(
"Item",
row.item_code,
true,
frappe.utils.escape_html(row.item_code)
);
const missing_supplier = item_suppliers.find((row) => !row.supplier);
if (missing_supplier) {
frappe.throw(
__("Select a Supplier for Item {0}", [
frappe.utils.get_form_link("Item", missing_supplier.item_code, true),
])
);
frappe.throw(__("Select a Supplier for Item {0}", [item_link(missing_supplier)]));
}
const invalid_qty = item_suppliers.find(
(row) => flt(row.qty) <= 0 || flt(row.qty) > flt(row.pending_qty)
);
if (invalid_qty) {
const pending_qty = `${format_number(invalid_qty.pending_qty)} ${frappe.utils.escape_html(
invalid_qty.uom
)}`;
frappe.throw(
__("Quantity for Item {0} must be greater than zero and cannot exceed {1}", [
frappe.utils.get_form_link("Item", invalid_qty.item_code, true),
`<b>${format_number(invalid_qty.pending_qty)} ${invalid_qty.uom}</b>`,
item_link(invalid_qty),
`<b>${pending_qty}</b>`,
])
);
}