nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-20 03:47:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #59118 from frappe/mergify/bp/version-15-hotfix/pr-59104

Browse Source 
fix(stock): allow zero completed quantity and handle process loss in job cards (backport #59104)
This commit is contained in:
Sudharsanan Ashok
2026-09-17 19:22:55 +05:30
committed by GitHub
parent d6d0400f76 1e862b232c
commit 1ad584fddc
3 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/manufacturing/doctype/job_card/job_card.js
View File

@@ -355,6 +355,10 @@ frappe.ui.form.on("Job Card", {
default: frm.doc.for_quantity - frm.doc.total_completed_qty,
},
(data) => {
if (data.qty < 0) {
frappe.throw(__("Completed Quantity cannot be negative"));
}
frm.events.complete_job(frm, "Complete", data.qty);
},
__("Enter Value")

3
erpnext/manufacturing/doctype/job_card/job_card.py
View File

@@ -755,9 +755,10 @@ class JobCard(Document):
def set_process_loss(self):
precision = self.precision("total_completed_qty")
should_set_process_loss = self.total_completed_qty or self.process_loss_qty
self.process_loss_qty = 0.0
if self.total_completed_qty and self.for_quantity > self.total_completed_qty:
if should_set_process_loss and self.for_quantity > self.total_completed_qty:
self.process_loss_qty = flt(self.for_quantity, precision) - flt(
self.total_completed_qty, precision
)

13
erpnext/manufacturing/doctype/job_card/test_job_card.py
View File

@@ -1157,6 +1157,19 @@ class TestJobCard(FrappeTestCase):
assert_operating_costs(s4, 3, [s, s3])
def test_set_process_loss(self):
nothing_done = frappe.new_doc("Job Card")
nothing_done.for_quantity = 10
nothing_done.total_completed_qty = 0
nothing_done.set_process_loss()
self.assertEqual(nothing_done.process_loss_qty, 0)
all_process_loss = frappe.new_doc("Job Card")
all_process_loss.for_quantity = 10
all_process_loss.process_loss_qty = 10
all_process_loss.set_process_loss()
self.assertEqual(all_process_loss.process_loss_qty, 10)
def create_bom_with_multiple_operations():
"Create a BOM with multiple operations and Material Transfer against Job Card"