nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-12 14:11:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #56296 from nabinhait/opportunity-auto-close-default-days

Browse Source 
fix(crm): drive opportunity auto-close days from CRM Settings, not a hardcoded fallback
This commit is contained in:
Nabin Hait
2026-06-22 14:04:00 +05:30
committed by GitHub
parent 4ba1f5214e f1b6a7d690
commit 19ba681e16
3 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/crm/doctype/opportunity/opportunity.py
View File

@@ -399,8 +399,8 @@ def set_multiple_status(names: str | list[str], status: str):
def auto_close_opportunity():
"""auto close the `Replied` Opportunities after 7 days"""
auto_close_after_days = frappe.db.get_single_value("CRM Settings", "close_opportunity_after_days") or 15
"""Auto close `Replied` Opportunities inactive for the days configured in CRM Settings."""
auto_close_after_days = frappe.db.get_single_value("CRM Settings", "close_opportunity_after_days")
table = frappe.qb.DocType("Opportunity")
opportunities = (

1
erpnext/patches.txt
View File

@@ -489,3 +489,4 @@ erpnext.patches.v16_0.submit_existing_product_bundles #1
erpnext.patches.v16_0.migrate_subscription_generate_invoice_at
erpnext.patches.v16_0.rename_subscription_billing_period_fields
erpnext.patches.v16_0.drop_redundant_serial_no_index_from_sabb
erpnext.patches.v16_0.set_default_close_opportunity_after_days

12
erpnext/patches/v16_0/set_default_close_opportunity_after_days.py Normal file
View File

@@ -0,0 +1,12 @@
import frappe
def execute():
"""Backfill the default for CRM Settings.close_opportunity_after_days.
The auto-close logic used to fall back to 15 days in code. Now that the fallback is removed,
existing sites that never set the value (left blank / 0) need it filled in so opportunities
keep auto-closing on the same schedule.
"""
if not frappe.db.get_single_value("CRM Settings", "close_opportunity_after_days"):
frappe.db.set_single_value("CRM Settings", "close_opportunity_after_days", 15)