nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-02-19 01:25:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: migration; make it resilient against old, non-conforming data

Browse Source
This commit is contained in:
David
2024-12-06 17:52:54 +01:00
parent 93e9517f5d
commit 14a57795d5
1 changed files with 35 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
erpnext/patches/v15_0/migrate_old_item_wise_tax_detail_data_format.py
View File

@@ -26,33 +26,43 @@ def execute():
updated_tax_details = {}
needs_update = False
for item, tax_data in json.loads(doc.item_wise_tax_detail).items():
if isinstance(tax_data, list) and len(tax_data) == 2:
updated_tax_details[item] = ItemWiseTaxDetail(
tax_rate=tax_data[0],
tax_amount=tax_data[1],
# can't be reliably reconstructed since it depends on the tax type
# (actual, net, previous line total, previous line net, etc)
net_amount=0.0,
)
needs_update = True
# intermediate patch version of the originating PR
elif isinstance(tax_data, list) and len(tax_data) == 3:
updated_tax_details[item] = ItemWiseTaxDetail(
tax_rate=tax_data[0],
tax_amount=tax_data[1],
net_amount=tax_data[2],
)
needs_update = True
elif isinstance(tax_data, str):
updated_tax_details[item] = ItemWiseTaxDetail(
tax_rate=flt(tax_data),
tax_amount=0.0,
net_amount=0.0,
)
try:
item_iterator = json.loads(doc.item_wise_tax_detail).items()
except AttributeError as e:
# This is stale data from 2009 found in a database
if json.loads(doc.item_wise_tax_detail) == 1:
# meaning: replace with an empty {}
needs_update = True
else:
updated_tax_details[item] = tax_data
raise e
else:
for item, tax_data in item_iterator:
if isinstance(tax_data, list) and len(tax_data) == 2:
updated_tax_details[item] = ItemWiseTaxDetail(
tax_rate=tax_data[0],
tax_amount=tax_data[1],
# can't be reliably reconstructed since it depends on the tax type
# (actual, net, previous line total, previous line net, etc)
net_amount=0.0,
)
needs_update = True
# intermediate patch version of the originating PR
elif isinstance(tax_data, list) and len(tax_data) == 3:
updated_tax_details[item] = ItemWiseTaxDetail(
tax_rate=tax_data[0],
tax_amount=tax_data[1],
net_amount=tax_data[2],
)
needs_update = True
elif isinstance(tax_data, str):
updated_tax_details[item] = ItemWiseTaxDetail(
tax_rate=flt(tax_data),
tax_amount=0.0,
net_amount=0.0,
)
needs_update = True
else:
updated_tax_details[item] = tax_data
if needs_update:
frappe.db.set_value(