nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-15 07:28:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #56226 from mihir-kandoi/pg-item-variant-update-join

Browse Source 
fix(controllers): make update_variant_attribute_values Postgres-valid (drop UPDATE..JOIN)
This commit is contained in:
Mihir Kandoi
2026-06-21 10:13:50 +05:30
committed by GitHub
parent 016097da2e 598864f0be
commit 0e88f59196
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
erpnext/controllers/item_variant.py
View File

@@ -169,13 +169,17 @@ def update_variant_attribute_values(item_attribute):
for old_value, new_value in value_map.items():
attribute_value_case = attribute_value_case.when(attribute_value == old_value, new_value)
(
frappe.qb.update(item_variant_table)
.join(item_table)
.on(item_table.name == item_variant_table.parent)
.set(attribute_value, attribute_value_case.else_(attribute_value))
# Postgres has no UPDATE ... JOIN; restrict to variant items via a subquery on the parent instead.
variant_items = (
frappe.qb.from_(item_table)
.select(item_table.name)
.where(item_table.variant_of.isnotnull())
.where(item_table.variant_of != "")
)
(
frappe.qb.update(item_variant_table)
.set(attribute_value, attribute_value_case.else_(attribute_value))
.where(item_variant_table.parent.isin(variant_items))
.where(item_variant_table.attribute == item_attribute.name)
.where(attribute_value.isin(list(value_map)))
).run()