nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-12 14:11:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(opportunity): cover item details, auto-close and prospect sync

Browse Source 
Add tests for get_item_details, auto_close_opportunity (a stale Replied
opportunity is closed, a recent one is not) and the Opportunity -> Prospect
opportunity sync. Opportunity controller coverage 62% -> 80%.
This commit is contained in:
Nabin Hait
2026-06-22 12:45:12 +05:30
parent 61c2e7ad6e
commit 017e09eaac
1 changed files with 55 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
erpnext/crm/doctype/opportunity/test_opportunity.py
View File

@@ -2,11 +2,12 @@
# See license.txt
import frappe
from frappe.utils import now_datetime, random_string, today
from frappe.utils import add_days, now_datetime, random_string, today
from erpnext.crm.doctype.lead.mapper import make_customer
from erpnext.crm.doctype.lead.test_lead import make_lead
from erpnext.crm.doctype.opportunity.mapper import make_quotation
from erpnext.crm.doctype.opportunity.opportunity import auto_close_opportunity, get_item_details
from erpnext.crm.utils import get_linked_communication_list
from erpnext.tests.utils import ERPNextTestSuite
@@ -130,6 +131,59 @@ class TestOpportunity(ERPNextTestSuite):
self.assertRaises(frappe.ValidationError, opp.declare_enquiry_lost, [], [], "x")
self.assertNotEqual(opp.status, "Lost")
def test_get_item_details(self):
details = get_item_details("_Test Item")
self.assertEqual(details["item_name"], frappe.db.get_value("Item", "_Test Item", "item_name"))
self.assertEqual(details["uom"], frappe.db.get_value("Item", "_Test Item", "stock_uom"))
# an unknown item returns blank fields rather than erroring
self.assertEqual(get_item_details("_Non Existent Item XYZ")["item_name"], "")
def test_auto_close_replied_opportunity(self):
days = frappe.db.get_single_value("CRM Settings", "close_opportunity_after_days") or 15
stale = make_opportunity(with_items=0)
fresh = make_opportunity(with_items=0)
for opp in (stale, fresh):
frappe.db.set_value("Opportunity", opp.name, "status", "Replied", update_modified=False)
# age only the stale opportunity past the threshold
frappe.db.set_value(
"Opportunity",
stale.name,
"modified",
add_days(now_datetime(), -(days + 1)),
update_modified=False,
)
auto_close_opportunity()
self.assertEqual(frappe.db.get_value("Opportunity", stale.name, "status"), "Closed")
self.assertEqual(frappe.db.get_value("Opportunity", fresh.name, "status"), "Replied")
def test_opportunity_synced_to_prospect(self):
prospect_name = "_Test Prospect For Opportunity"
if not frappe.db.exists("Prospect", prospect_name):
frappe.get_doc(
{"doctype": "Prospect", "company_name": prospect_name, "company": "_Test Company"}
).insert(ignore_permissions=True)
opp = frappe.get_doc(
{
"doctype": "Opportunity",
"company": "_Test Company",
"opportunity_from": "Prospect",
"party_name": prospect_name,
"opportunity_type": "Sales",
"sales_stage": "Prospecting",
"transaction_date": today(),
}
).insert(ignore_permissions=True)
prospect = frappe.get_doc("Prospect", prospect_name)
linked = {d.opportunity: d for d in prospect.opportunities}
self.assertIn(opp.name, linked)
self.assertEqual(linked[opp.name].stage, "Prospecting")
def _ensure_master(doctype, fieldname, value):
if not frappe.db.exists(doctype, value):