Commit Graph

34 Commits

Author SHA1 Message Date
jebsolutions
b0bde877d1 fixes bug #2270 reported by volga629 (#2276)
Please do further testing/review and give comments and suggest cleanup, etc.

This bug is only tripped if all of the following are true:
a) fax send fails
b) email notification of fax failure also fails
c) Other?

how to test
- have a 100% working fax to email setup.
- Change Advanced->defaults->email and set the port to be something invalid.
- e.g. smtp port 9999 is invalid
- send a test fax to something without a fax
- e.g. I just faxed my own DID which does NOT have fax answering

- each time the phone rings answer...wait 5 seconds, and then hang up
- note: it will retry sending the fax 5 times so repeat the above.

- on the last try it will give up, and try to send the failure email
- the email will fail (bad port) and then it will insert the failed email into v_emails
- the insert will fail and nothing in v_emails

Error was caused by trying to insert '' into the domain_uuid field.
'' is invalid in a uuid field, but null is okay.

The null is caused by no x-headers being passed.  So these two fields end up null:
$headers["X-FusionPBX-Domain-UUID"]
$headers["X-FusionPBX-Email-Type"]

Ignoring unset/uninitialized variables hides bugs.

Fix: feed the X-Header in the calling lua code.
2016-12-27 17:49:57 -07:00
FusionPBX
b6281a84c4 Update fax_retry.lua 2016-12-02 00:52:10 -07:00
FusionPBX
96708bdeea Update fax_retry.lua
Prevent a nill error for email_address.
2016-12-01 23:57:17 -07:00
FusionPBX
c029516f07 Update fax_retry.lua 2016-12-01 23:47:32 -07:00
Alexey Melnichuk
a7c972ba2d Fix. Create dbh object in fax_retry.lua (#2168) 2016-11-23 23:14:58 -07:00
Alexey Melnichuk
ae17af5fa5 Add. Use params in fax_retry.lua (#2114) 2016-11-21 22:07:02 -07:00
Alexey Melnichuk
09f2d8fa43 Allow use odbc to store files (record/voicemail) in database. (#1535)
* Change. Allow use odbc to store files (record/voicemail) in database.

* Fix. Generate correct default config.
2016-09-04 13:05:47 -06:00
mafoo
b7555579bf WhitespaceClean-resources/install/scripts
whitespace pass over files
for reference regex that was used s/[ \t]+(\r?\n)/\1/
2016-03-11 13:21:52 +00:00
markjcrane
1a49780757 Fix the FAX retry email. 2016-01-05 13:19:02 -07:00
markjcrane
0bf4e1b794 Remove absolute_codec_string='PCMU,PCMA' from fax_retry.lua as it is not allowing PCMA. 2015-09-30 21:01:17 -06:00
markjcrane
2e6f90fb80 Fax keep local updates. 2015-08-16 02:01:37 -06:00
Alexey Melnichuk
3e16e69adb Revert "Revert "Change. Use require "resources.functions.config" to load co…" 2015-08-11 05:06:33 +03:00
FusionPBX
2a2dd209df Revert "Change. Use require "resources.functions.config" to load config file." 2015-08-10 11:50:29 -06:00
FusionPBX
559aa61fbd Merge pull request #1053 from moteus/require_config
Change. Use `require "resources.functions.config"` to load config file.
2015-08-10 11:31:35 -06:00
Alexey Melnichuk
703b61636a Change. Use only require to load function.
Fix. Remove multiple definition of same function.
2015-08-10 12:43:06 +04:00
markjcrane
173e9ca691 Fix fax_retry.lua for domain_name and domain_uuid. Add [FAX] to the logging to the console. 2015-07-30 19:32:18 -06:00
Alexey Melnichuk
3da348fff0 Change. Use require "resources.functions.config" to load config file.
Change. Move `script_dir` definition into config file.
2015-07-22 13:20:51 +04:00
Mark Crane
f994329edb FAX sure domain_uuid is set at the right time. 2015-06-30 18:01:30 +00:00
Nate Jones
95e965b108 Fax: Upgrade script to generate and store meta-data from existing fax files, fix Lua script to insert correct fax file path into db, JavaScript prompt corrections, adjust redirect after send to use new interface, fix delete so files on file system are removed (using path from db), fix paging and sorting on Inbox and Sent, fix TIF to PDF conversion for viewing sent/received faxes (if PDF version not present). 2015-05-09 05:22:29 +00:00
Mark Crane
0985d0a840 Fix some line spacing and one tab in fax_retry.lua. 2015-04-27 16:45:23 +00:00
Mark Crane
6d863601de Update fax retry to use fax_files.lua. 2015-04-27 14:32:29 +00:00
luis daniel lucio quiroz
56872c05a2 for_fax now on fax 2015-01-27 14:51:57 +00:00
luis daniel lucio quiroz
226651280e accountcode now on fax, PCMU/A as absolute codec string 2015-01-26 19:54:52 +00:00
Nate Jones
f31db4fec8 Fax Retry (LUA): nulls to nils. 2014-11-29 15:24:02 +00:00
Mark Crane
24be63aa3b Add fax_uuid to the fax_retry.lua script 2014-09-09 11:03:00 +00:00
Mark Crane
ceaef7bdb2 Add domain_uuid, fax_date, fax_epoch to fax retry 2014-09-07 05:18:35 +00:00
Mark Crane
29d01ee57a Add Fax logging. 2014-09-04 07:12:47 +00:00
Mark Crane
3c536c1e56 Change the wording of the comment in fax_retry.lua 2014-07-23 21:02:28 +00:00
Mark Crane
500b6477cb Fix the fax_success null issue wit fax retry 2014-04-30 05:04:54 +00:00
Mark Crane
6ec053708f Fix the white space and tabs issues with fax_retry.lua. 2014-02-19 06:15:53 +00:00
Mark Crane
bf831a7bf5 Fix a bug with fax_success in a few places it was set to numeric 0 but used in an IF statement as a string. Fax retry worked in many situations but this bug prevented it from working all the time. 2014-01-21 21:55:38 +00:00
Mark Crane
e55589f623 Faxing if the from_address is null then use the email_address. 2013-08-14 23:07:35 +00:00
James Rose
4d884015db Bug Fixes. Script errors due to nil value channel variables, and now sends email on busy fax. Better statistics reporting, busy/failure retries work as expected so it will now retry the same ecm/t38 type after a busy. 2013-07-01 20:08:08 +00:00
Mark Crane
567e554cb7 Move the includes/install to resources/install 2013-06-09 02:42:36 +00:00