From 2d5bce9481d4c451641ee022a23632d70704db1b Mon Sep 17 00:00:00 2001
From: koldoa <koldo@aingeru.com>
Date: Fri, 16 Oct 2015 15:04:31 +0200
Subject: [PATCH] Changed readdir to scandir so we can get sorted template
 names

---
 app/devices/device_edit.php       | 39 +++++++++++++++++--------------
 app/extensions/extension_edit.php | 11 +++++----
 2 files changed, 28 insertions(+), 22 deletions(-)

diff --git a/app/devices/device_edit.php b/app/devices/device_edit.php
index 26bf7d747c..85885a9467 100644
--- a/app/devices/device_edit.php
+++ b/app/devices/device_edit.php
@@ -555,32 +555,35 @@ require_once "resources/require.php";
 	echo "<select id='device_template' name='device_template' class='formfld'>\n";
 	echo "<option value=''></option>\n";
 
-	if ($dh = opendir($template_dir)) {
-		while($dir = readdir($dh)) {
-			if($file != "." && $dir != ".." && $dir[0] != '.') {
-				if(is_dir($template_dir . "/" . $dir)) {
-					echo "<optgroup label='$dir'>";
-					if($dh_sub = opendir($template_dir.'/'.$dir)) {
-						while($dir_sub = readdir($dh_sub)) {
-							if($file_sub != '.' && $dir_sub != '..' && $dir_sub[0] != '.') {
-								if(is_dir($template_dir . '/' . $dir .'/'. $dir_sub)) {
-									if ($device_template == $dir."/".$dir_sub) {
-										echo "<option value='".$dir."/".$dir_sub."' selected='selected'>".$dir."/".$dir_sub."</option>\n";
-									}
-									else {
-										echo "<option value='".$dir."/".$dir_sub."'>".$dir."/".$dir_sub."</option>\n";
+	if (is_dir($template_dir)) {
+			$templates = scandir($template_dir);
+			foreach($templates as $dir) {
+				if($file != "." && $dir != ".." && $dir[0] != '.') {
+					if(is_dir($template_dir . "/" . $dir)) {
+						echo "<optgroup label='$dir'>";
+						$dh_sub=$template_dir . "/" . $dir;
+						if(is_dir($dh_sub)) {
+							$templates_sub = scandir($dh_sub);
+							foreach($templates_sub as $dir_sub) {
+								if($file_sub != '.' && $dir_sub != '..' && $dir_sub[0] != '.') {
+									if(is_dir($template_dir . '/' . $dir .'/'. $dir_sub)) {
+										if ($device_template == $dir."/".$dir_sub) {
+											echo "<option value='".$dir."/".$dir_sub."' selected='selected'>".$dir."/".$dir_sub."</option>\n";
+										}
+										else {
+											echo "<option value='".$dir."/".$dir_sub."'>".$dir."/".$dir_sub."</option>\n";
+										}
 									}
 								}
 							}
+							closedir($dh_sub);
 						}
-						closedir($dh_sub);
+						echo "</optgroup>";
 					}
-					echo "</optgroup>";
 				}
 			}
+			closedir($dh);
 		}
-		closedir($dh);
-	}
 	echo "</select>\n";
 	echo "<br />\n";
 	echo $text['description-device_template']."\n";
diff --git a/app/extensions/extension_edit.php b/app/extensions/extension_edit.php
index 9d1739a0ea..b156b79358 100644
--- a/app/extensions/extension_edit.php
+++ b/app/extensions/extension_edit.php
@@ -1258,13 +1258,16 @@ if (count($_POST) > 0 && strlen($_POST["persistformvar"]) == 0) {
 			$template_dir = $device->get_template_dir();
 			echo "<select id='device_template' name='device_template' class='formfld'>\n";
 			echo "<option value=''></option>\n";
-			if($dh = opendir($template_dir)) {
-				while($dir = readdir($dh)) {
+			if (is_dir($template_dir)) {
+				$templates = scandir($template_dir);
+				foreach($templates as $dir) {
 					if($file != "." && $dir != ".." && $dir[0] != '.') {
 						if(is_dir($template_dir . "/" . $dir)) {
 							echo "<optgroup label='$dir'>";
-							if($dh_sub = opendir($template_dir.'/'.$dir)) {
-								while($dir_sub = readdir($dh_sub)) {
+							$dh_sub=$template_dir . "/" . $dir;
+							if(is_dir($dh_sub)) {
+								$templates_sub = scandir($dh_sub);
+								foreach($templates_sub as $dir_sub) {
 									if($file_sub != '.' && $dir_sub != '..' && $dir_sub[0] != '.') {
 										if(is_dir($template_dir . '/' . $dir .'/'. $dir_sub)) {
 											if ($device_template == $dir."/".$dir_sub) {