diff --git a/app/log_viewer/log_viewer.php b/app/log_viewer/log_viewer.php index 2259b5ea8b..fecdcd7af9 100644 --- a/app/log_viewer/log_viewer.php +++ b/app/log_viewer/log_viewer.php @@ -40,6 +40,12 @@ else { $row_style["0"] = "row_style0"; $row_style["1"] = "row_style1"; +//set a default line number value (off) + if ($_POST['ln'] == '') { $_POST['ln'] = 0; } + +//set a default ordinal (descending) + if ($_POST['ord'] == '') { $_POST['ord'] = "asc"; } + //set a default file size if (strlen($_POST['fs']) == 0) { $_POST['fs'] = "32"; } @@ -70,12 +76,14 @@ echo " \n"; echo " Log Viewer
\n"; echo " \n"; echo "
\n"; -echo " \n"; -echo " \n"; -echo " \n"; +echo " \n"; +echo " "; +echo " "; +echo " Display KB"; +echo " "; echo " \n"; echo "
\n"; -echo " \n"; +echo " \n"; if (permission_exists('log_download')) { echo " \n"; } @@ -133,15 +141,18 @@ if (permission_exists('log_view')) { $file_size = filesize($log_file); + /* + // removed: duplicate of above if (isset($_POST['submit'])) { if (strlen($_POST['fs']) == 0) { $_POST['fs'] = "32"; } } + */ echo ""; echo ""; echo "
Syntax Highlighted
"; - $user_filesize = '32000'; + $user_filesize = '32768'; if (isset($_POST['submit'])) { if (!is_numeric($_POST['fs'])){ echo ""; @@ -151,12 +162,12 @@ if (permission_exists('log_view')) { $user_filesize='1000'; } else { - $user_filesize = $_POST['fs'] * 1000; + $user_filesize = $_POST['fs'] * 1024; } } //echo "Log File Size: " . $file_size . " bytes.
"; - echo "Viewing the last " . $user_filesize . " of " . $file_size . " bytes.

"; + echo "
Displaying the last " . number_format($user_filesize,0,'.',',') . " of " . number_format($file_size,0,'.',',') . " bytes.


"; $file = fopen($log_file, "r") or exit("Unable to open file!"); @@ -218,23 +229,33 @@ if (permission_exists('log_view')) { } } - echo "" ; - /* testing to see if style is what crashes firefox on large logfiles... - echo "

";*/ - echo $log_line; - echo "
"; + $ary_output[] = "".$log_line."
"; $noprint = true; } } + if ($noprint !== true){ //more firefox workaround... //echo "

"; - echo "" ; - echo $log_line; - //echo "

"; - echo "
"; + + $ary_output[] = "".$log_line."
"; + } + } + + // output according to ordinal selected + if ($_POST['ord'] == 'desc') { + $ary_output = array_reverse($ary_output); + $adj_index = 0; + } + else { + $adj_index = 1; + } + foreach ($ary_output as $index => $line) { + if ($line != '
') { + if ($_POST['ln']) { + $line_num = "".($index + $adj_index)."   "; + } + echo $line_num." ".$line; } }