diff --git a/app/gateways/gateways.php b/app/gateways/gateways.php index c3a58d0c44..614e1dbbf9 100644 --- a/app/gateways/gateways.php +++ b/app/gateways/gateways.php @@ -129,7 +129,7 @@ //prepare to page the results $rows_per_page = ($_SESSION['domain']['paging']['numeric'] != '') ? $_SESSION['domain']['paging']['numeric'] : 50; - $param = "&order_by=".$order_by."&order=".$order; + $param = "&order_by=".escape($order_by)."&order=".escape($order); if (!isset($_GET['page'])) { $_GET['page'] = 0; } $_GET['page'] = check_str($_GET['page']); list($paging_controls, $rows_per_page, $var_3) = paging($total_gateways, $param, $rows_per_page); @@ -187,35 +187,35 @@ echo "\n"; echo "\n"; - if ($total_gateways > 0) { + if (is_array($gateways)) { foreach($gateways as $row) { - $tr_link = (permission_exists('gateway_edit')) ? "href='gateway_edit.php?id=".$row['gateway_uuid']."'" : null; + $tr_link = (permission_exists('gateway_edit')) ? "href='gateway_edit.php?id=".escape($row['gateway_uuid'])."'" : null; echo "\n"; if ($_GET['show'] == "all" && permission_exists('gateway_all')) { if (strlen($_SESSION['domains'][$row['domain_uuid']]['domain_name']) > 0) { - $domain = $_SESSION['domains'][$row['domain_uuid']]['domain_name']; + $domain = escape($_SESSION['domains'][$row['domain_uuid']]['domain_name']); } else { $domain = $text['label-global']; } - echo " ".$domain."\n"; + echo " ".escape($domain)."\n"; } echo " "; if (permission_exists('gateway_edit')) { - echo "".$row["gateway"].""; + echo "".escape($row["gateway"]).""; } else { echo $row["gateway"]; } echo "\n"; - echo " ".$row["context"]."\n"; + echo " ".escape($row["context"])."\n"; if ($fp) { if ($row["enabled"] == "true") { $response = switch_gateway_status($row["gateway_uuid"]); if ($response == "Invalid Gateway!") { //not running echo " ".$text['label-status-stopped']."\n"; - echo " ".$text['label-action-start']."\n"; + echo " ".$text['label-action-start']."\n"; echo "  \n"; } else { @@ -224,8 +224,8 @@ $xml = new SimpleXMLElement($response); $state = $xml->state; echo " ".$text['label-status-running']."\n"; - echo " ".$text['label-action-stop']."\n"; - echo " ".$state."\n"; //REGED, NOREG, UNREGED + echo " ".$text['label-action-stop']."\n"; + echo " ".escape($state)."\n"; //REGED, NOREG, UNREGED } catch(Exception $e) { //echo $e->getMessage(); @@ -237,20 +237,20 @@ echo "  \n"; echo "  \n"; } - echo " ".$row["hostname"]."\n"; + echo " ".escape($row["hostname"])."\n"; if ($row["enabled"] == "true") { echo " ".$text['label-true']."\n"; } else { echo " ".$text['label-false']."\n"; } - echo " ".$row["description"]." \n"; + echo " ".escape($row["description"])." \n"; echo " "; if (permission_exists('gateway_edit')) { - echo "$v_link_label_edit"; + echo "$v_link_label_edit"; } if (permission_exists('gateway_delete')) { - echo "$v_link_label_delete"; + echo "$v_link_label_delete"; } echo " \n"; echo "\n";