diff --git a/app/voicemail_greetings/voicemail_greetings.php b/app/voicemail_greetings/voicemail_greetings.php index 4f4d5f29e7..5219dc452a 100644 --- a/app/voicemail_greetings/voicemail_greetings.php +++ b/app/voicemail_greetings/voicemail_greetings.php @@ -17,7 +17,7 @@ The Initial Developer of the Original Code is Mark J Crane - Portions created by the Initial Developer are Copyright (C) 2008-2017 + Portions created by the Initial Developer are Copyright (C) 2008-2018 the Initial Developer. All Rights Reserved. Contributor(s): @@ -29,7 +29,7 @@ require_once "resources/require.php"; require_once "resources/check_auth.php"; -//deny access if the user extension is not assigned +//check permissions if (!permission_exists('voicemail_greeting_view')) { if (!is_extension_assigned($voicemail_id)) { echo "access denied"; @@ -366,7 +366,7 @@ echo "
\n"; if (permission_exists('voicemail_greeting_upload')) { echo "
\n"; - echo " \n"; + echo " \n"; echo " \n"; } echo "      \n"; @@ -380,22 +380,22 @@ echo "
"; echo "".$text['title']."\n"; echo "

\n"; - echo $text['description']." ".$voicemail_id."\n"; + echo $text['description']." ".escape($voicemail_id)."\n"; echo "

\n"; echo "\n"; echo "\n"; echo "\n"; - echo th_order_by('greeting_id', $text['table-number'], $order_by, $order, '', "width='20'", "id=".$voicemail_id); - echo th_order_by('greeting_name', $text['table-name'], $order_by, $order, '', '', "id=".$voicemail_id); + echo th_order_by('greeting_id', $text['table-number'], $order_by, $order, '', "width='20'", "id=".escape($voicemail_id)); + echo th_order_by('greeting_name', $text['table-name'], $order_by, $order, '', '', "id=".escape($voicemail_id)); if ($_SESSION['voicemail']['storage_type']['text'] != 'base64') { - echo th_order_by('greeting_filename', $text['table-filename'], $order_by, $order, '', '', "id=".$voicemail_id); + echo th_order_by('greeting_filename', $text['table-filename'], $order_by, $order, '', '', "id=".escape($voicemail_id)); echo "\n"; } if (permission_exists('voicemail_greeting_play') || permission_exists('voicemail_greeting_download')) { echo "\n"; } - echo th_order_by('greeting_description', $text['table-description'], $order_by, $order, '', '', "id=".$voicemail_id); + echo th_order_by('greeting_description', $text['table-description'], $order_by, $order, '', '', "id=".escape($voicemail_id)); echo "\n"; echo "\n"; @@ -405,22 +405,22 @@ if ($_SESSION['voicemail']['storage_type']['text'] == 'base64') { $colspan = $colspan - 2; } if (!(permission_exists('voicemail_greeting_edit') || permission_exists('voicemail_greeting_delete'))) { $colspan = $colspan - 1; } - if ($greeting_count > 0) { + if (is_array($greetings) { foreach($greetings as $row) { //playback progress bar if (permission_exists('voicemail_greeting_play')) { - echo "\n"; + echo "\n"; } - $tr_link = (permission_exists('voicemail_greeting_edit')) ? "href='voicemail_greeting_edit.php?id=".$row['voicemail_greeting_uuid']."&voicemail_id=".$voicemail_id."'" : null; + $tr_link = (permission_exists('voicemail_greeting_edit')) ? "href='voicemail_greeting_edit.php?id=".escape($row['voicemail_greeting_uuid'])."&voicemail_id=".escape($voicemail_id)."'" : null; echo "\n"; echo " \n"; - echo " \n"; - echo " \n"; + echo " \n"; + echo " \n"; if ($_SESSION['voicemail']['storage_type']['text'] != 'base64') { - echo " \n"; + echo " \n"; $tmp_filesize = filesize($v_greeting_dir.'/'.$row['greeting_filename']); $tmp_filesize = byte_convert($tmp_filesize); echo " \n"; @@ -436,21 +436,21 @@ case "mp3" : $greeting_type = "audio/mpeg"; break; case "ogg" : $greeting_type = "audio/ogg"; break; } - echo ""; - echo "".$v_link_label_play.""; + echo ""; + echo "".$v_link_label_play.""; } if (permission_exists('voicemail_greeting_download')) { - echo "".$v_link_label_download.""; + echo "".$v_link_label_download.""; } echo " \n"; } - echo " \n"; + echo " \n"; echo " \n"; echo "\n"; @@ -464,4 +464,5 @@ //include the footer require_once "resources/footer.php"; + ?>
 ".$text['table-size']."".$text['label-tools']."\n"; echo "
".$row['greeting_id']."".$row['greeting_name']."".escape($row['greeting_id'])."".escape($row['greeting_name'])."".$row['greeting_filename']."".escape($row['greeting_filename'])."".$tmp_filesize."".$row['greeting_description']." ".escape($row['greeting_description'])." \n"; if (permission_exists('voicemail_greeting_edit')) { - echo "$v_link_label_edit"; + echo "$v_link_label_edit"; } if (permission_exists('voicemail_greeting_delete')) { - echo "$v_link_label_delete"; + echo "$v_link_label_delete"; } echo "