From c1ad629d95d80c83ab5ab3f482130715f7a05981 Mon Sep 17 00:00:00 2001
From: fusionate <nate@fusionpbx.com>
Date: Fri, 8 Dec 2023 01:41:01 +0000
Subject: [PATCH] Operator Panel - Consistify refresh button, minor
 adjustments.

---
 app/basic_operator_panel/index.php            | 20 ++++++++-----------
 .../resources/content.php                     | 10 ++++++----
 2 files changed, 14 insertions(+), 16 deletions(-)

diff --git a/app/basic_operator_panel/index.php b/app/basic_operator_panel/index.php
index 54d04a4763..153c6a9494 100644
--- a/app/basic_operator_panel/index.php
+++ b/app/basic_operator_panel/index.php
@@ -349,11 +349,11 @@ unset($refresh_default);
 //refresh controls
 	function refresh_stop() {
 		clearInterval(interval_timer_id);
-		if (document.getElementById('refresh_state')) { document.getElementById('refresh_state').innerHTML = "<img src='resources/images/refresh_paused.png' style='width: 16px; height: 16px; border: none; margin-top: 1px; cursor: pointer;' onclick='refresh_start();' alt=\"<?php echo $text['label-refresh_enable']?>\" title=\"<?php echo $text['label-refresh_enable']?>\">"; }
+		if (document.getElementById('refresh_state')) { document.getElementById('refresh_state').innerHTML = "<?php echo button::create(['type'=>'button','title'=>$text['label-refresh_enable'],'icon'=>'pause','onclick'=>'refresh_start()']); ?>"; }
 	}
 
 	function refresh_start() {
-		if (document.getElementById('refresh_state')) { document.getElementById('refresh_state').innerHTML = "<img src='resources/images/refresh_active.gif' style='width: 16px; height: 16px; border: none; margin-top: 3px; cursor: pointer;' alt=\"<?php echo $text['label-refresh_pause']?>\" title=\"<?php echo $text['label-refresh_pause']?>\">"; }
+		if (document.getElementById('refresh_state')) { document.getElementById('refresh_state').innerHTML = "<?php echo button::create(['type'=>'button','title'=>$text['label-refresh_pause'],'icon'=>'sync-alt fa-spin','onclick'=>'refresh_stop()']); ?>"; }
 		refresh_stop();
 		interval_timer_id = setInterval( function() {
 			url = source_url;
@@ -405,7 +405,7 @@ unset($refresh_default);
 		if (ext != '' && chan_uuid != '') {
 			cmd = get_eavesdrop_cmd(ext, chan_uuid, document.getElementById('eavesdrop_dest').value);
 			if (cmd != '') {
-				send_cmd(cmd)
+				send_cmd(cmd);
 			}
 		}
 	}
@@ -430,7 +430,7 @@ unset($refresh_default);
 		}
 		xmlhttp.open("GET",url,false);
 		xmlhttp.send(null);
-		document.getElementById('cmd_reponse').innerHTML=xmlhttp.responseText;
+		document.getElementById('cmd_response').innerHTML=xmlhttp.responseText;
 	}
 
 //hide/show destination input field
@@ -588,15 +588,11 @@ if (is_array($_SESSION['user']['extension'])) {
 	}
 }
 
-?>
-
-<div id='ajax_reponse'></div>
-<div id='cmd_reponse' style='display: none;'></div>
-<br><br>
-
-<?php
+echo "<div id='ajax_reponse'></div>\n";
+echo "<div id='cmd_response' style='display: none;'></div>\n";
+echo "<br><br>\n";
 
 //include the footer
 	require_once "resources/footer.php";
 
-?>
+?>
\ No newline at end of file
diff --git a/app/basic_operator_panel/resources/content.php b/app/basic_operator_panel/resources/content.php
index bb220e1b64..7489dba58e 100644
--- a/app/basic_operator_panel/resources/content.php
+++ b/app/basic_operator_panel/resources/content.php
@@ -154,8 +154,8 @@ echo "		</td>\n";
 echo "		<td valign='top' align='right' width='50%' nowrap>\n";
 echo "			<table cellpadding='0' cellspacing='0' border='0'>\n";
 echo "				<tr>\n";
-echo "					<td valign='middle' nowrap='nowrap' style='padding-right: 15px' id='refresh_state'>\n";
-echo "						<img src='resources/images/refresh_active.gif' style='width: 16px; height: 16px; border: none; margin-top: 3px; cursor: pointer;' onclick='refresh_stop();' alt=\"".$text['label-refresh_pause']."\" title=\"".$text['label-refresh_pause']."\">\n";
+echo "					<td valign='middle' nowrap='nowrap' style='padding-right: 15px'>\n";
+echo "						<span id='refresh_state'>".button::create(['type'=>'button','title'=>$text['label-refresh_pause'],'icon'=>'sync-alt fa-spin','onclick'=>'refresh_stop()'])."</span>";
 echo "					</td>\n";
 
 if (permission_exists('operator_panel_eavesdrop')) {
@@ -164,8 +164,10 @@ if (permission_exists('operator_panel_eavesdrop')) {
 		echo "				<input type='hidden' id='eavesdrop_dest' value=\"".(($_REQUEST['eavesdrop_dest'] == '') ? $_SESSION['user']['extension'][0]['destination'] : escape($_REQUEST['eavesdrop_dest']))."\">\n";
 		echo "				<img src='resources/images/eavesdrop.png' style='width: 12px; height: 12px; border: none; margin: 0px 5px; cursor: help;' title='".$text['description-eavesdrop_destination']."' align='absmiddle'>\n";
 		echo "				<select class='formfld' style='margin-right: 5px;' align='absmiddle' onchange=\"document.getElementById('eavesdrop_dest').value = this.options[this.selectedIndex].value; refresh_start();\" onfocus='refresh_stop();'>\n";
-		if (is_array($_SESSION['user']['extensions'])) foreach ($_SESSION['user']['extensions'] as $user_extension) {
-			echo "				<option value='".escape($user_extension)."' ".(($_REQUEST['eavesdrop_dest'] == $user_extension) ? "selected" : null).">".escape($user_extension)."</option>\n";
+		if (is_array($_SESSION['user']['extensions'])) {
+			foreach ($_SESSION['user']['extensions'] as $user_extension) {
+				echo "			<option value='".escape($user_extension)."' ".(($_REQUEST['eavesdrop_dest'] == $user_extension) ? "selected" : null).">".escape($user_extension)."</option>\n";
+			}
 		}
 		echo "				</select>\n";
 	}