From b5f85d43caabaf6726d7aa334fd21593fdd0135a Mon Sep 17 00:00:00 2001
From: FusionPBX <markjcrane@gmail.com>
Date: Mon, 26 Oct 2020 18:07:40 -0600
Subject: [PATCH] Update dialplan_outbound_add.php

Adjust permissions to work better for admin if the outbound_route_add permissions is set.
---
 .../dialplan_outbound_add.php                 | 96 ++++++++++---------
 1 file changed, 52 insertions(+), 44 deletions(-)

diff --git a/app/dialplan_outbound/dialplan_outbound_add.php b/app/dialplan_outbound/dialplan_outbound_add.php
index 7ee05958d5..b33f058583 100644
--- a/app/dialplan_outbound/dialplan_outbound_add.php
+++ b/app/dialplan_outbound/dialplan_outbound_add.php
@@ -684,6 +684,11 @@
 				} //end foreach
 			}
 
+		//add the dialplan permission
+			$p = new permissions;
+			$p->add("dialplan_add", "temp");
+			$p->add("dialplan_detail_add", "temp");
+
 		//save to the data
 			$database = new database;
 			$database->app_name = 'outbound_routes';
@@ -699,6 +704,10 @@
 			$dialplans->uuid = $dialplan_uuid;
 			$dialplans->xml();
 
+		//remove the temporary permission
+			$p->delete("dialplan_add", "temp");
+			$p->delete("dialplan_detail_add", "temp");
+
 		//clear the cache
 			$cache = new cache;
 			$cache->delete("dialplan:".$dialplan_context);
@@ -806,50 +815,49 @@ function type_onchange(dialplan_detail_type) {
 	echo "</td>\n";
 	echo "<td width='70%' class='vtable' align='left'>\n";
 
-	if (if_group("superadmin")) {
-		echo "<script>\n";
-		echo "var Objs;\n";
-		echo "\n";
-		echo "function changeToInput(obj){\n";
-		echo "	tb=document.createElement('INPUT');\n";
-		echo "	tb.type='text';\n";
-		echo "	tb.name=obj.name;\n";
-		echo "	tb.setAttribute('class', 'formfld');\n";
-		echo "	tb.setAttribute('style', 'width: 400px;');\n";
-		echo "	tb.value=obj.options[obj.selectedIndex].value;\n";
-		echo "	tbb=document.createElement('INPUT');\n";
-		echo "	tbb.setAttribute('class', 'btn');\n";
-		echo "	tbb.setAttribute('style', 'margin-left: 4px;');\n";
-		echo "	tbb.type='button';\n";
-		echo "	tbb.value=$('<div />').html('&#9665;').text();\n";
-		echo "	tbb.objs=[obj,tb,tbb];\n";
-		echo "	tbb.onclick=function(){ Replace(this.objs); }\n";
-		echo "	obj.parentNode.insertBefore(tb,obj);\n";
-		echo "	obj.parentNode.insertBefore(tbb,obj);\n";
-		echo "	obj.parentNode.removeChild(obj);\n";
-		echo "}\n";
-		echo "\n";
-		echo "function Replace(obj){\n";
-		echo "	obj[2].parentNode.insertBefore(obj[0],obj[2]);\n";
-		echo "	obj[0].parentNode.removeChild(obj[1]);\n";
-		echo "	obj[0].parentNode.removeChild(obj[2]);\n";
-		echo "}\n";
-		echo "function update_dialplan_expression() {\n";
-		echo "	if ( document.getElementById('dialplan_expression_select').value == 'CUSTOM_PREFIX' ) {\n";
-		echo "		document.getElementById('outbound_prefix').value = '';\n";
-		echo "		$('#enter_custom_outbound_prefix_box').slideDown();\n";
-		echo "	} else { \n";
-		echo "		document.getElementById('dialplan_expression').value += document.getElementById('dialplan_expression_select').value + '\\n';\n";
-		echo "		document.getElementById('outbound_prefix').value = '';\n";
-		echo "		$('#enter_custom_outbound_prefix_box').slideUp();\n";
-		echo "	}\n";
-		echo "}\n";
-		echo "function update_outbound_prefix() {\n";
-		echo "	document.getElementById('dialplan_expression').value += '^' + document.getElementById('outbound_prefix').value + '(\\\d*)\$' + '\\n';\n";
-		echo "}\n";
-		echo "</script>\n";
-		echo "\n";
-	}
+	echo "<script>\n";
+	echo "var Objs;\n";
+	echo "\n";
+	echo "function changeToInput(obj){\n";
+	echo "	tb=document.createElement('INPUT');\n";
+	echo "	tb.type='text';\n";
+	echo "	tb.name=obj.name;\n";
+	echo "	tb.setAttribute('class', 'formfld');\n";
+	echo "	tb.setAttribute('style', 'width: 400px;');\n";
+	echo "	tb.value=obj.options[obj.selectedIndex].value;\n";
+	echo "	tbb=document.createElement('INPUT');\n";
+	echo "	tbb.setAttribute('class', 'btn');\n";
+	echo "	tbb.setAttribute('style', 'margin-left: 4px;');\n";
+	echo "	tbb.type='button';\n";
+	echo "	tbb.value=$('<div />').html('&#9665;').text();\n";
+	echo "	tbb.objs=[obj,tb,tbb];\n";
+	echo "	tbb.onclick=function(){ Replace(this.objs); }\n";
+	echo "	obj.parentNode.insertBefore(tb,obj);\n";
+	echo "	obj.parentNode.insertBefore(tbb,obj);\n";
+	echo "	obj.parentNode.removeChild(obj);\n";
+	echo "}\n";
+	echo "\n";
+	echo "function Replace(obj){\n";
+	echo "	obj[2].parentNode.insertBefore(obj[0],obj[2]);\n";
+	echo "	obj[0].parentNode.removeChild(obj[1]);\n";
+	echo "	obj[0].parentNode.removeChild(obj[2]);\n";
+	echo "}\n";
+	echo "function update_dialplan_expression() {\n";
+	echo "	if ( document.getElementById('dialplan_expression_select').value == 'CUSTOM_PREFIX' ) {\n";
+	echo "		document.getElementById('outbound_prefix').value = '';\n";
+	echo "		$('#enter_custom_outbound_prefix_box').slideDown();\n";
+	echo "	} else { \n";
+	echo "		document.getElementById('dialplan_expression').value += document.getElementById('dialplan_expression_select').value + '\\n';\n";
+	echo "		document.getElementById('outbound_prefix').value = '';\n";
+	echo "		$('#enter_custom_outbound_prefix_box').slideUp();\n";
+	echo "	}\n";
+	echo "}\n";
+	echo "function update_outbound_prefix() {\n";
+	echo "	document.getElementById('dialplan_expression').value += '^' + document.getElementById('outbound_prefix').value + '(\\\d*)\$' + '\\n';\n";
+	echo "}\n";
+	echo "</script>\n";
+	echo "\n";
+
 
 	//set the onchange
 	$onchange = '';