From b163e3d90649ea2e94cd8c8dcacfa46e33f5202b Mon Sep 17 00:00:00 2001
From: frytimo <tim@fusionpbx.com>
Date: Thu, 3 Jul 2025 15:12:32 -0300
Subject: [PATCH] Security fix for link in button (#7408)

* security fix for link in button

* Escape characters for button link
---
 resources/classes/button.php | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/resources/classes/button.php b/resources/classes/button.php
index d7786d7418..cc4a91cafe 100644
--- a/resources/classes/button.php
+++ b/resources/classes/button.php
@@ -108,7 +108,7 @@
 			//link
 				if (!empty($array['link'])) {
 					$anchor = "<a ";
-					$anchor .= "href='".$array['link']."' ";
+					$anchor .= "href='" . self::escape_href($array['link']) . "' ";
 					$anchor .= "target='".(!empty($array['target']) ? $array['target'] : '_self')."' ";
 					//ensure only margin* styles are applied to the anchor element
 					if (!empty($array['style']) && is_array($array['style']) && @sizeof($array['style']) != 0) {
@@ -132,6 +132,12 @@
 			return substr_count($value, "'") ? '"'.$value.'"' : "'".$value."'";
 		}
 
+		private static function escape_href(string $url): string {
+			// clear whitespace
+			$url = trim($url);
+
+			return htmlspecialchars($url, ENT_QUOTES, 'UTF-8');
+		}
 	}
 
 /*