Update check permisisons

app/access_controls/access_control_export.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('access_control_node_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('access_control_node_view')) {
 		echo "access denied";
 		exit;
 	}

app/access_controls/access_control_import.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('access_control_node_add')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('access_control_node_add')) {
 		echo "access denied";
 		exit;
 	}

app/access_controls/access_controls.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('access_control_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('access_control_view')) {
 		echo "access denied";
 		exit;
 	}
@@ -66,12 +63,6 @@
 					$obj->copy($access_controls);
 				}
 				break;
-			case 'toggle':
-				if (permission_exists('access_control_edit')) {
-					$obj = new access_controls;
-					$obj->toggle($access_controls);
-				}
-				break;
 			case 'delete':
 				if (permission_exists('access_control_delete')) {
 					$obj = new access_controls;

app/access_controls/access_controls_reload.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('access_control_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('access_control_view')) {
 		echo "access denied";
 		exit;
 	}

app/active_calls/active_calls.php

@@ -30,9 +30,7 @@ require_once dirname(__DIR__, 2) . "/resources/require.php";
 require_once "resources/check_auth.php";
 
 //check permissions
-if (permission_exists('call_active_view')) {
-	//access granted
-} else {
+if (!permission_exists('call_active_view')) {
 	echo "access denied";
 	exit;
 }

app/basic_operator_panel/autocomplete.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('contact_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('contact_view')) {
 		exit;
 	}
 

app/basic_operator_panel/exec.php

@@ -32,10 +32,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('operator_panel_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('operator_panel_view')) {
 		echo "access denied";
 		exit;
 	}

app/basic_operator_panel/index.php

@@ -30,10 +30,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('operator_panel_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('operator_panel_view')) {
 		echo "access denied";
 		exit;
 	}

app/basic_operator_panel/resources/content.php

@@ -29,10 +29,7 @@ require_once dirname(__DIR__, 3) . "/resources/require.php";
 require_once "resources/check_auth.php";
 
 //check permissions
-if (permission_exists('operator_panel_view')) {
-	//access granted
-}
-else {
+if (!permission_exists('operator_panel_view')) {
 	echo "access denied";
 	exit;
 }

app/bridges/bridge_imports.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('bridge_import')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('bridge_import')) {
 		echo "access denied";
 		exit;
 	}

app/bridges/bridges.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('bridge_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('bridge_view')) {
 		echo "access denied";
 		exit;
 	}

app/call_block/call_block.php

@@ -34,7 +34,8 @@
 
 //check permissions
 	if (!permission_exists('call_block_view')) {
-		echo "access denied"; exit;
+		echo "access denied";
+		exit;
 	}
 
 //add multi-lingual support

app/call_block/call_block_edit.php

@@ -33,7 +33,8 @@
 
 //check permissions
 	if (!permission_exists('call_block_edit') && !permission_exists('call_block_add')) {
-		echo "access denied"; exit;
+		echo "access denied";
+		exit;
 	}
 
 //add multi-lingual support

app/call_broadcast/call_broadcast.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('call_broadcast_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_broadcast_view')) {
 		echo "access denied";
 		exit;
 	}

app/call_broadcast/call_broadcast_edit.php

@@ -30,10 +30,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('call_broadcast_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_broadcast_edit')) {
 		echo "access denied";
 		exit;
 	}
@@ -76,7 +73,7 @@
 				{
 					$count++;
 					if ($count == 1) { continue; }
-					$getData = preg_split('/[ ,|]/', $getData[0], null, PREG_SPLIT_NO_EMPTY);
+					$getData = preg_split('/[ ,|]/', $getData[0], '', PREG_SPLIT_NO_EMPTY);
 					$separator = $getData[0];
 					$separator .= (isset($getData[1]) && $getData[1] != '')? '|'.$getData[1] : '';
 					$separator .= (isset($getData[2]) && $getData[2] != '')? ','.$getData[2] : '';

app/call_center_active/call_center_active.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('call_center_active_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_center_active_view')) {
 		echo "access denied";
 		exit;
 	}

app/call_center_active/call_center_active_inc.php

@@ -30,10 +30,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('call_center_active_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_center_active_view')) {
 		echo "access denied";
 		exit;
 	}

app/call_center_active/call_center_exec.php

@@ -32,10 +32,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('call_center_active_options')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_center_active_options')) {
 		echo "access denied";
 		exit;
 	}

app/call_center_active/call_center_queue.php

@@ -29,10 +29,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('call_center_active_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_center_active_view')) {
 		echo "access denied";
 		exit;
 	}

app/call_centers/call_center_agent_edit.php

@@ -30,10 +30,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('call_center_agent_add') || permission_exists('call_center_agent_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_center_agent_add') || !permission_exists('call_center_agent_edit')) {
 		echo "access denied";
 		exit;
 	}

app/call_centers/call_center_agent_status.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('call_center_agent_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_center_agent_view')) {
 		echo "access denied";
 		exit;
 	}

app/call_centers/call_center_agents.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('call_center_agent_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_center_agent_view')) {
 		echo "access denied";
 		exit;
 	}

app/call_centers/call_center_queue_edit.php

@@ -30,10 +30,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('call_center_queue_add') || permission_exists('call_center_queue_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_center_queue_add') || !permission_exists('call_center_queue_edit')) {
 		echo "access denied";
 		exit;
 	}

app/call_centers/cmd.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('call_center_queue_add') || permission_exists('call_center_queue_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_center_queue_add') || !permission_exists('call_center_queue_edit')) {
 		echo "access denied";
 		exit;
 	}

app/call_centers/resources/dashboard/call_center_agents.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('call_center_queue_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_center_queue_view')) {
 		echo "access denied";
 		exit;
 	}

app/call_flows/call_flow_edit.php

@@ -30,10 +30,7 @@
 
 //check permissions
 	require_once "resources/check_auth.php";
-	if (permission_exists('call_flow_add') || permission_exists('call_flow_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_flow_add') || !permission_exists('call_flow_edit')) {
 		echo "access denied";
 		exit;
 	}

app/call_flows/call_flows.php

@@ -30,10 +30,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('call_flow_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_flow_view')) {
 		echo "access denied";
 		exit;
 	}

app/call_forward/call_forward.php

@@ -34,10 +34,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('follow_me') || permission_exists('call_forward') || permission_exists('do_not_disturb')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('follow_me') || !permission_exists('call_forward') || !permission_exists('do_not_disturb')) {
 		echo "access denied";
 		exit;
 	}

app/call_forward/call_forward_edit.php

@@ -30,10 +30,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('follow_me') || permission_exists('call_forward') || permission_exists('do_not_disturb')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('follow_me') || !permission_exists('call_forward') || !permission_exists('do_not_disturb')) {
 		echo "access denied";
 		exit;
 	}

app/call_forward/resources/dashboard/call_forward.php

@@ -2,13 +2,10 @@
 
 //includes files
 	require_once  dirname(__DIR__, 4) . "/resources/require.php";
+	require_once "resources/check_auth.php";
 
 //check permissions
-	require_once "resources/check_auth.php";
-	if (permission_exists('follow_me') || permission_exists('call_forward') || permission_exists('do_not_disturb')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('follow_me') || !permission_exists('call_forward') || !permission_exists('do_not_disturb')) {
 		echo "access denied";
 		exit;
 	}

app/call_recordings/call_recordings.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('call_recording_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_recording_view')) {
 		echo "access denied";
 		exit;
 	}

app/calls_active/calls_active.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('call_active_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_active_view')) {
 		echo "access denied";
 		exit;
 	}

app/calls_active/calls_active_inc.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('call_active_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_active_view')) {
 		echo "access denied";
 		exit;
 	}

app/calls_active/calls_exec.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('call_active_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('call_active_view')) {
 		echo "access denied";
 		exit;
 	}

app/click_to_call/click_to_call.php

@@ -35,10 +35,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('click_to_call_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('click_to_call_view')) {
 		echo "access denied";
 		exit;
 	}

app/conference_centers/conference_center_edit.php

@@ -26,13 +26,10 @@
 
 //includes files
 	require_once dirname(__DIR__, 2) . "/resources/require.php";
+	require_once "resources/check_auth.php";
 
 //check permissions
-	require_once "resources/check_auth.php";
-	if (permission_exists('conference_center_add') || permission_exists('conference_center_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_center_add') || !permission_exists('conference_center_edit')) {
 		echo "access denied";
 		exit;
 	}

app/conference_centers/conference_centers.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('conference_center_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_center_view')) {
 		echo "access denied";
 		exit;
 	}

app/conference_centers/conference_room_edit.php

@@ -30,10 +30,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('conference_room_add') || permission_exists('conference_room_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_room_add') || !permission_exists('conference_room_edit')) {
 		echo "access denied";
 		exit;
 	}

app/conference_centers/conference_rooms.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('conference_room_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_room_view')) {
 		echo "access denied";
 		exit;
 	}

app/conference_centers/conference_session_details.php

@@ -29,10 +29,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('conference_session_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_session_view')) {
 		echo "access denied";
 		exit;
 	}

app/conference_centers/conference_sessions.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('conference_session_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_session_view')) {
 		echo "access denied";
 		exit;
 	}

app/conference_controls/conference_control_detail_edit.php

@@ -26,13 +26,10 @@
 
 //includes files
 	require_once dirname(__DIR__, 2) . "/resources/require.php";
+	require_once "resources/check_auth.php";
 
 //check permissions
-	require_once "resources/check_auth.php";
-	if (permission_exists('conference_control_detail_add') || permission_exists('conference_control_detail_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_control_detail_add') || !permission_exists('conference_control_detail_edit')) {
 		echo "access denied";
 		exit;
 	}

app/conference_controls/conference_control_details.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('conference_control_detail_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_control_detail_view')) {
 		echo "access denied";
 		exit;
 	}

app/conference_controls/conference_control_edit.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('conference_control_add') || permission_exists('conference_control_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_control_add') || !permission_exists('conference_control_edit')) {
 		echo "access denied";
 		exit;
 	}

app/conference_controls/conference_controls.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('conference_control_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_control_view')) {
 		echo "access denied";
 		exit;
 	}

app/conference_profiles/conference_profile_edit.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('conference_profile_add') || permission_exists('conference_profile_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_profile_add') || !permission_exists('conference_profile_edit')) {
 		echo "access denied";
 		exit;
 	}

app/conference_profiles/conference_profile_param_edit.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('conference_profile_param_add') || permission_exists('conference_profile_param_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_profile_param_add') || !permission_exists('conference_profile_param_edit')) {
 		echo "access denied";
 		exit;
 	}

app/conference_profiles/conference_profile_params.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('conference_profile_param_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_profile_param_view')) {
 		echo "access denied";
 		exit;
 	}

app/conference_profiles/conference_profiles.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('conference_profile_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_profile_view')) {
 		echo "access denied";
 		exit;
 	}

app/conferences/conference_edit.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('conference_add') || permission_exists('conference_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_add') || !permission_exists('conference_edit')) {
 		echo "access denied";
 		exit;
 	}

app/conferences/conferences.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('conference_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_view')) {
 		echo "access denied";
 		exit;
 	}

app/conferences_active/conference_exec.php

@@ -41,10 +41,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('conference_active_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_active_view')) {
 		echo "access denied";
 		exit;
 	}

app/conferences_active/conference_interactive.php

@@ -30,10 +30,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('conference_interactive_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_interactive_view')) {
 		echo "access denied";
 		exit;
 	}

app/conferences_active/conference_interactive_inc.php

@@ -30,10 +30,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('conference_interactive_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_interactive_view')) {
 		echo "access denied";
 		exit;
 	}

app/conferences_active/conferences_active.php

@@ -30,10 +30,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('conference_active_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_active_view')) {
 		echo "access denied";
 		exit;
 	}

app/conferences_active/conferences_active_inc.php

@@ -30,10 +30,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('conference_active_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('conference_active_view')) {
 		echo "access denied";
 		exit;
 	}

app/database_transactions/database_transaction_edit.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('database_transaction_add') || permission_exists('database_transaction_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('database_transaction_add') || !permission_exists('database_transaction_edit')) {
 		echo "access denied";
 		exit;
 	}

app/database_transactions/database_transactions.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('database_transaction_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('database_transaction_view')) {
 		echo "access denied";
 		exit;
 	}

app/destinations/destination_download.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('destination_export')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('destination_export')) {
 		echo "access denied";
 		exit;
 	}

app/destinations/destination_edit.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('destination_add') || permission_exists('destination_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('destination_add') || !permission_exists('destination_edit')) {
 		echo "access denied";
 		exit;
 	}
@@ -577,8 +574,8 @@
 										if (isset($action_array[0]) && !empty($action_array[0])) {
 											if ($destination->valid($action_array[0].':'.$action_array[1])) {
 												//set variables from the action array
-												$action_app = $action_array[0];
-												$action_data = $action_array[1];
+												$action_app = $action_array[0] ?? '';
+												$action_data = $action_array[1] ?? '';
 
 												//allow specific api commands
 												$allowed_commands = array();
@@ -589,7 +586,7 @@
 												}
 												$action_data = xml::sanitize($action_data);
 												foreach ($allowed_commands as $allowed_command) {
-													$action_data = str_replace('#{'.$allowed_command, '${'.$allowed_command, $action_data);
+													$action_data = str_replace('#{'.$allowed_command, '${'.$allowed_command, $action_data ?? '');
 												}
 
 												//add the action to the dialplan xml

app/destinations/destination_imports.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('destination_import')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('destination_import')) {
 		echo "access denied";
 		exit;
 	}

app/destinations/destination_summary.php

@@ -30,10 +30,7 @@
 	//require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('destination_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('destination_view')) {
 		echo "access denied";
 		exit;
 	}

app/destinations/destinations.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('destination_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('destination_view')) {
 		echo "access denied";
 		exit;
 	}
@@ -65,12 +62,6 @@
 //process the http post data by action
 	if (!empty($action) && !empty($destinations)) {
 		switch ($action) {
-			case 'toggle':
-				if (permission_exists('destination_edit')) {
-					$obj = new destinations;
-					$obj->toggle($destinations);
-				}
-				break;
 			case 'delete':
 				if (permission_exists('destination_delete')) {
 					$obj = new destinations;

app/destinations/resources/destinations.php

@@ -5,10 +5,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('destination_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('destination_view')) {
 		echo "access denied";
 		exit;
 	}

app/devices/cmd.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists("device_key_add") || permission_exists("device_key_edit") || if_group("superadmin")) {
-		//access granted
-	}
-	else {
+	if (!permission_exists("device_key_add") || !permission_exists("device_key_edit")) {
 		echo "access denied";
 		exit;
 	}

app/devices/device_copy.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('device_add')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('device_add')) {
 		echo "access denied";
 		exit;
 	}

app/devices/device_download.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('device_export')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('device_export')) {
 		echo "access denied";
 		exit;
 	}

app/devices/device_edit.php

@@ -27,10 +27,7 @@
 
 //check permissions
 	require_once "resources/check_auth.php";
-	if (permission_exists('device_add') || permission_exists('device_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('device_add') || !permission_exists('device_edit')) {
 		echo "access denied";
 		exit;
 	}

app/devices/device_imports.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('device_add')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('device_add')) {
 		echo "access denied";
 		exit;
 	}

app/devices/device_profile_copy.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('device_profile_add')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('device_profile_add')) {
 		echo "access denied";
 		exit;
 	}

app/devices/device_profile_edit.php

@@ -25,13 +25,10 @@
 
 //includes files
 	require_once dirname(__DIR__, 2) . "/resources/require.php";
+	require_once "resources/check_auth.php";
 
 //check permissions
-	require_once "resources/check_auth.php";
-	if (permission_exists('device_profile_add') || permission_exists('device_profile_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('device_profile_add') || !permission_exists('device_profile_edit')) {
 		echo "access denied";
 		exit;
 	}

app/devices/device_profiles.php

@@ -29,10 +29,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('device_profile_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('device_profile_view')) {
 		echo "access denied";
 		exit;
 	}

app/devices/device_vendor_edit.php

@@ -26,13 +26,10 @@
 
 //includes files
 	require_once dirname(__DIR__, 2) . "/resources/require.php";
+	require_once "resources/check_auth.php";
 
 //check permissions
-	require_once "resources/check_auth.php";
-	if (permission_exists('device_vendor_add') || permission_exists('device_vendor_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('device_vendor_add') || !permission_exists('device_vendor_edit')) {
 		echo "access denied";
 		exit;
 	}

app/devices/device_vendor_function_edit.php

@@ -26,6 +26,13 @@
 
 //includes files
 	require_once dirname(__DIR__, 2) . "/resources/require.php";
+	require_once "resources/check_auth.php";
+
+//check permissions
+	if (!permission_exists('device_vendor_function_add') || !permission_exists('device_vendor_function_edit')) {
+		echo "access denied";
+		exit;
+	}
 
 //add multi-lingual support
 	$language = new text;
@@ -34,16 +41,6 @@
 //set the defaults
 	$device_vendor_function_uuid = '';
 
-//check permissions
-	require_once "resources/check_auth.php";
-	if (permission_exists('device_vendor_function_add') || permission_exists('device_vendor_function_edit')) {
-		//access granted
-	}
-	else {
-		echo "access denied";
-		exit;
-	}
-
 //action add or update
 	if (!empty($_REQUEST["id"]) && is_uuid($_REQUEST["id"])) {
 		$action = "update";

app/devices/device_vendor_functions.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('device_vendor_function_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('device_vendor_function_view')) {
 		echo "access denied";
 		exit;
 	}

app/devices/device_vendor_restore.php

@@ -27,13 +27,10 @@
 
 //includes files
 	require_once dirname(__DIR__, 2) . "/resources/require.php";
+	require_once "resources/check_auth.php";
 
 //check permissions
-	require_once "resources/check_auth.php";
-	if (permission_exists('device_vendor_restore')) {
-			//access granted
-	}
-	else {
+	if (!permission_exists('device_vendor_restore')) {
 		echo "access denied";
 		exit;
 	}

app/devices/device_vendors.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('device_vendor_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('device_vendor_view')) {
 		echo "access denied";
 		exit;
 	}

app/devices/devices.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('device_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('device_view')) {
 		echo "access denied";
 		exit;
 	}

app/dialplan_inbound/dialplan_inbound_add.php

@@ -32,10 +32,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('inbound_route_add')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('inbound_route_add')) {
 		echo $text['label-access-denied'];
 		exit;
 	}

app/dialplan_outbound/dialplan_outbound_add.php

@@ -34,10 +34,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('outbound_route_add')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('outbound_route_add')) {
 		echo "access denied";
 		exit;
 	}

app/dialplans/dialplan_add.php

@@ -29,10 +29,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('dialplan_add')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('dialplan_add')) {
 		echo "access denied";
 		exit;
 	}

app/dialplans/dialplan_edit.php

@@ -31,19 +31,16 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('dialplan_add')
-		|| permission_exists('dialplan_edit')
-		|| permission_exists('inbound_route_add')
-		|| permission_exists('inbound_route_edit')
-		|| permission_exists('outbound_route_add')
-		|| permission_exists('outbound_route_edit')
-		|| permission_exists('fifo_add')
-		|| permission_exists('fifo_edit')
-		|| permission_exists('time_condition_add')
-		|| permission_exists('time_condition_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('dialplan_add')
+		|| !permission_exists('dialplan_edit')
+		|| !permission_exists('inbound_route_add')
+		|| !permission_exists('inbound_route_edit')
+		|| !permission_exists('outbound_route_add')
+		|| !permission_exists('outbound_route_edit')
+		|| !permission_exists('fifo_add')
+		|| !permission_exists('fifo_edit')
+		|| !permission_exists('time_condition_add')
+		|| !permission_exists('time_condition_edit')) {
 		echo "access denied";
 		exit;
 	}

app/dialplans/dialplan_xml.php

@@ -30,10 +30,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('dialplan_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('dialplan_edit')) {
 		echo "access denied";
 		exit;
 	}

app/dialplans/dialplans.php

@@ -25,16 +25,13 @@
 */
 
 //includes files
-global $settings, $domain_uuid, $database;
-require_once dirname(__DIR__, 2) . "/resources/require.php";
+	global $settings, $domain_uuid, $database;
+	require_once dirname(__DIR__, 2) . "/resources/require.php";
 	require_once "resources/check_auth.php";
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('dialplan_view') || permission_exists('inbound_route_view') || permission_exists('outbound_route_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('dialplan_view') || !permission_exists('inbound_route_view') || !permission_exists('outbound_route_view')) {
 		echo "access denied";
 		exit;
 	}

app/email_queue/email_queue.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('email_queue_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('email_queue_view')) {
 		echo "access denied";
 		exit;
 	}

app/email_queue/email_queue_delete.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('email_queue_delete')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('email_queue_delete')) {
 		echo "access denied";
 		exit;
 	}

app/email_queue/email_queue_edit.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('email_queue_add') || permission_exists('email_queue_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('email_queue_add') || !permission_exists('email_queue_edit')) {
 		echo "access denied";
 		exit;
 	}

app/email_queue/resources/command/send.php

@@ -82,7 +82,7 @@
 	}
 
 //get the command line parameters
-	$options = getopt(null, $long_options);
+	$options = getopt('', $long_options);
 
 //set the values from the command line parameters
 	foreach($options as $option_key => $option_value) {

app/emergency/emergency.php

@@ -6,10 +6,7 @@ require_once "resources/check_auth.php";
 require_once "resources/paging.php";
 
 //check permissions
-if (permission_exists('emergency_logs_view')) {
-	//access granted
-}
-else {
+if (!permission_exists('emergency_logs_view')) {
 	echo "access denied";
 	exit;
 }
@@ -20,9 +17,9 @@ $text = $language->get();
 
 //get the http post data
 if (!empty($_POST['emergency_logs']) && is_array($_POST['emergency_logs'])) {
-	$action = $_POST['action'];
+	$action = $_POST['action'] ?? '';
 	$search = $_POST['search'] ?? '';
-	$emergency_logs = $_POST['emergency_logs'];
+	$emergency_logs = $_POST['emergency_logs'] ?? '';
 }
 
 //set permissions for CDR details and call recordings

app/event_guard/event_guard_log_edit.php

@@ -25,10 +25,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('event_guard_log_add') || permission_exists('event_guard_log_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('event_guard_log_add') || !permission_exists('event_guard_log_edit')) {
 		echo "access denied";
 		exit;
 	}

app/event_guard/event_guard_logs.php

@@ -29,10 +29,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('event_guard_log_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('event_guard_log_view')) {
 		echo "access denied";
 		exit;
 	}

app/event_guard/resources/service/event_guard.php

@@ -447,7 +447,7 @@
 		if ($firewall_name == 'iptables') {
 			$command = $firewall_path.'/./iptables -L '.$filter.' -n --line-numbers | grep "'.$ip_address.' " | cut -d " " -f1';
 			$line_number = trim(shell($command));
-			echo "\n". $command . " line ".__line__." result ".$result."\n";
+			echo "\n". $command . " line ".__line__."\n";
 			if (is_numeric($line_number)) {
 				//$result = shell('iptables -D INPUT '.$line_number);
 				$command = $firewall_path.'/./iptables -D '.$filter.' '.$line_number;

app/extension_settings/extension_setting_edit.php

@@ -26,10 +26,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('extension_setting_add') || permission_exists('extension_setting_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('extension_setting_add') || !permission_exists('extension_setting_edit')) {
 		echo "access denied";
 		exit;
 	}

app/extension_settings/extension_settings.php

@@ -26,10 +26,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('extension_setting_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('extension_setting_view')) {
 		echo "access denied";
 		exit;
 	}

app/extension_settings/resources/classes/extension_settings.php

@@ -35,6 +35,11 @@
 		const app_name = 'extension_settings';
 		const app_uuid = '1416a250-f6e1-4edc-91a6-5c9b883638fd';
 
+		/**
+		* declare the public variables
+		*/
+		public $extension_uuid;
+
 		/**
 		 * Set in the constructor. Must be a database object and cannot be null.
 		 * @var database Database Object
@@ -60,7 +65,7 @@
 		private $domain_uuid;
 
 		/**
-		* declare the variables
+		* declare the private variables
 		*/
 		private $name;
 		private $table;
@@ -68,7 +73,6 @@
 		private $toggle_values;
 		private $description_field;
 		private $location;
-		private $extension_uuid;
 
 		/**
 		 * called when the object is created

app/extensions/extension_copy.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('extension_copy')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('extension_copy')) {
 		echo "access denied";
 		exit;
 	}

app/extensions/extension_download.php

@@ -30,10 +30,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('extension_export')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('extension_export')) {
 		echo "access denied";
 		exit;
 	}

app/extensions/extension_edit.php

@@ -30,10 +30,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('extension_add') || permission_exists('extension_edit')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('extension_add') || !permission_exists('extension_edit')) {
 		echo "access denied";
 		exit;
 	}

app/extensions/extension_imports.php

@@ -29,10 +29,7 @@
 	require_once "resources/check_auth.php";
 
 //check permissions
-	if (permission_exists('extension_import')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('extension_import')) {
 		echo "access denied";
 		exit;
 	}

app/extensions/extensions.php

@@ -31,10 +31,7 @@
 	require_once "resources/paging.php";
 
 //check permissions
-	if (permission_exists('extension_view')) {
-		//access granted
-	}
-	else {
+	if (!permission_exists('extension_view')) {
 		echo "access denied";
 		exit;
 	}