From a91bfefc271e170d151f02cba6e23746cd7afb29 Mon Sep 17 00:00:00 2001 From: markjcrane Date: Sat, 10 Oct 2015 12:09:37 -0700 Subject: [PATCH] Correct the syntax and make it more efficient. --- core/default_settings/default_setting_edit.php | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/core/default_settings/default_setting_edit.php b/core/default_settings/default_setting_edit.php index 46b0970406..a01525bff0 100644 --- a/core/default_settings/default_setting_edit.php +++ b/core/default_settings/default_setting_edit.php @@ -100,9 +100,9 @@ if (count($_POST) > 0 && strlen($_POST["persistformvar"]) == 0) { $prep_statement = $db->prepare(check_sql($sql)); $prep_statement->execute(); $result = $prep_statement->fetchAll(PDO::FETCH_NAMED); - $var_action = "add" - foreach ($result as &$row) { - $var_action = "update" + $var_action = "add"; + foreach ($result as $row) { + $var_action = "update"; } unset ($prep_statement); @@ -111,16 +111,14 @@ if (count($_POST) > 0 && strlen($_POST["persistformvar"]) == 0) { $sql = "update from v_vars "; $sql = "set var_value = '".$default_setting_value."' "; $sql .= "where var_name = 'timezone' "; - $prep_statement = $db->prepare(check_sql($sql)); - $prep_statement->execute(); + $db->query($sql); unset($sql); } else { $sql = "insert into v_vars "; $sql .= "(var_uuid, var_name, var_value, var_cat, var_enabled) "; $sql .= "values ('".uuid()."', 'timezone', '$default_setting_value', 'Defaults', 'true'); "; - $prep_statement = $db->prepare(check_sql($sql)); - $prep_statement->execute(); + $db->query($sql); unset($sql); } }