Prevent more PHP warnings (#7609)

* Prevent more PHP warnings

* Update call_broadcast_edit.php

* Update call_center_agent_edit.php

* Update call_flow_edit.php

* Update call_center_queue_edit.php

* Update conference_center_edit.php

* Update conference_room_edit.php

* Update conference_control_detail_edit.php

* Update conference_control_edit.php

* Update conference_profile_edit.php

* Update conference_edit.php

* Update conference_profile_param_edit.php

* Update destination_edit.php

* Update device_edit.php

* Update dialplan_inbound_add.php

* Update dialplan_outbound_add.php

* Update dialplan_add.php

* Update dialplan_edit.php

* Update event_guard_logs.php

* Update extension_setting_edit.php

* Update extension_edit.php

* Update fax_edit.php

* Update fifo_edit.php

* Update ivr_menu_edit.php

* Update phrase_edit.php

* Update ring_group_edit.php

* Update sip_profile_edit.php

* Update stream_edit.php

* Update time_condition_edit.php

* Update var_edit.php

* Update voicemail_edit.php

* Update xml_cdr_search.php

* Update dashboard_widget_edit.php

* Update domain_edit.php

* Update group_edit.php

* Update user_edit.php

* Update gateway_edit.php
This commit is contained in:
Alex
2025-11-11 13:39:51 -07:00
committed by markjcrane
parent 69db088925
commit 987c6f7cb8
37 changed files with 146 additions and 64 deletions

View File

@@ -281,6 +281,9 @@
unset($sql, $parameters, $row);
}
//set the defaults
$call_block_enabled = $call_block_enabled ?? true;
//get the extensions
if (permission_exists('call_block_all') || permission_exists('call_block_extension')) {
$sql = "select extension_uuid, extension, number_alias, user_context, description from v_extensions ";

View File

@@ -17,7 +17,7 @@
The Initial Developer of the Original Code is
Mark J Crane <markjcrane@fusionpbx.com>
Portions created by the Initial Developer are Copyright (C) 2008-2024
Portions created by the Initial Developer are Copyright (C) 2008-2025
the Initial Developer. All Rights Reserved.
Contributor(s):
@@ -311,6 +311,9 @@ if (!empty($_POST) && empty($_POST["persistformvar"])) {
unset($sql, $parameters, $row);
}
//set the defaults
$broadcast_avmd = $broadcast_avmd ?? true;
//create token
$object = new token;
$token = $object->create($_SERVER['PHP_SELF']);

View File

@@ -309,7 +309,7 @@
if (empty($agent_no_answer_delay_time)) { $agent_no_answer_delay_time = "30"; }
if (empty($agent_reject_delay_time)) { $agent_reject_delay_time = "90"; }
if (empty($agent_busy_delay_time)) { $agent_busy_delay_time = "90"; }
if ($agent_record === null) { $agent_record = false; }
$agent_record = $agent_record ?? false;
//create token
$object = new token;

View File

@@ -682,7 +682,8 @@
unset($sounds);
}
//set the default values
//set default values
$queue_greeting = $queue_greeting ?? '';
$queue_strategy = $queue_strategy ?? "longest-idle-agent";
$queue_moh_sound = $queue_moh_sound ?? "\$\${hold_music}";
$queue_time_base_score = $queue_time_base_score ?? "system";
@@ -691,12 +692,13 @@
$queue_max_wait_time_with_no_agent_time_reached = $queue_max_wait_time_with_no_agent_time_reached ?? "30";
$queue_tier_rule_wait_second = $queue_tier_rule_wait_second ?? "30";
$queue_discard_abandoned_after = $queue_discard_abandoned_after ?? "900";
$queue_context = $queue_context ?? $domain_name;
$queue_record_template = $queue_record_template ?? 'false';
$queue_tier_rules_apply = $queue_tier_rules_apply ?? false;
$queue_tier_rule_wait_multiply_level = $queue_tier_rule_wait_multiply_level ?? true;
$queue_tier_rule_no_agent_no_wait = $queue_tier_rule_no_agent_no_wait ?? true;
$queue_abandoned_resume_allowed = $queue_abandoned_resume_allowed ?? false;
$queue_announce_sound = $queue_announce_sound ?? '';
$queue_context = $queue_context ?? $domain_name;
//create token
$object = new token;

View File

@@ -352,6 +352,9 @@
unset ($sql, $parameters, $result, $row);
}
//set the defaults
$call_flow_enabled = $call_flow_enabled ?? true;
//set the context for users that are not in the superadmin group
if (empty($call_flow_context)) {
$call_flow_context = $_SESSION['domain_name'];

View File

@@ -224,8 +224,9 @@
unset($sql, $parameters, $row);
}
//set defaults
if (empty($conference_center_pin_length)) { $conference_center_pin_length = 9; }
//set the defaults
$conference_center_pin_length = $conference_center_pin_length ?? 9;
$conference_center_enabled = $conference_center_enabled ?? true;
//get the sounds
$sounds = new sounds;

View File

@@ -471,6 +471,18 @@
unset($sql, $parameters, $row);
}
//set the defaults
$profile = $profile ?? 'default';
$record = $record ?? false;
$wait_mod = $wait_mod ?? true;
$moderator_endconf = $moderator_endconf ?? false;
$announce_name = $announce_name ?? true;
$announce_count = $announce_count ?? true;
$announce_recording = $announce_recording ?? true;
$mute = $mute ?? false;
$enabled = $enabled ?? true;
$sounds = $sounds ?? false;
//get the users assigned to this conference room
$sql = "select u.username, u.user_uuid, r.conference_room_user_uuid ";
$sql .= "from v_users as u, v_conference_room_users as r ";
@@ -500,9 +512,6 @@
$users = $database->select($sql, $parameters ?? null, 'all');
unset($sql, $parameters);
//set default profile
if (empty($profile)) { $profile = 'default'; }
//get default pins
if (empty($moderator_pin)) {
$moderator_pin = get_conference_pin($pin_length ?? '', $conference_room_uuid ?? '');
@@ -660,8 +669,8 @@
echo " <span class='switch'>\n";
}
echo " <select class='formfld' id='record' name='record'>\n";
echo " <option value='false' ".($record === false ? "selected='selected'" : null).">".$text['option-false']."</option>\n";
echo " <option value='true' ".($record === true ? "selected='selected'" : null).">".$text['option-true']."</option>\n";
echo " <option value='false' ".($record === false ? "selected='selected'" : null).">".$text['option-false']."</option>\n";
echo " </select>\n";
if ($input_toggle_style_switch) {
echo " <span class='slider'></span>\n";
@@ -720,8 +729,8 @@
echo " <span class='switch'>\n";
}
echo " <select class='formfld' id='moderator_endconf' name='moderator_endconf'>\n";
echo " <option value='false' ".($moderator_endconf === false ? "selected='selected'" : null).">".$text['option-false']."</option>\n";
echo " <option value='true' ".($moderator_endconf === true ? "selected='selected'" : null).">".$text['option-true']."</option>\n";
echo " <option value='false' ".($moderator_endconf === false ? "selected='selected'" : null).">".$text['option-false']."</option>\n";
echo " </select>\n";
if ($input_toggle_style_switch) {
echo " <span class='slider'></span>\n";
@@ -811,8 +820,8 @@
echo " <span class='switch'>\n";
}
echo " <select class='formfld' id='mute' name='mute'>\n";
echo " <option value='false' ".($mute === false ? "selected='selected'" : null).">".$text['option-false']."</option>\n";
echo " <option value='true' ".($mute === true ? "selected='selected'" : null).">".$text['option-true']."</option>\n";
echo " <option value='false' ".($mute === false ? "selected='selected'" : null).">".$text['option-false']."</option>\n";
echo " </select>\n";
if ($input_toggle_style_switch) {
echo " <span class='slider'></span>\n";
@@ -879,8 +888,8 @@
echo " <span class='switch'>\n";
}
echo " <select class='formfld' id='sounds' name='sounds'>\n";
echo " <option value='false' ".($sounds === false ? "selected='selected'" : null).">".$text['option-false']."</option>\n";
echo " <option value='true' ".($sounds === true ? "selected='selected'" : null).">".$text['option-true']."</option>\n";
echo " <option value='false' ".($sounds === false ? "selected='selected'" : null).">".$text['option-false']."</option>\n";
echo " </select>\n";
if ($input_toggle_style_switch) {
echo " <span class='slider'></span>\n";

View File

@@ -148,6 +148,9 @@
unset($sql, $parameters, $row);
}
//set the defaults
$control_enabled = $control_enabled ?? true;
//create token
$object = new token;
$token = $object->create($_SERVER['PHP_SELF']);

View File

@@ -140,6 +140,9 @@
unset($sql, $parameters, $row);
}
//set the defaults
$control_enabled = $control_enabled ?? true;
//create token
$object = new token;
$token = $object->create($_SERVER['PHP_SELF']);

View File

@@ -141,6 +141,9 @@
unset($sql, $parameters);
}
//set the defaults
$profile_enabled = $profile_enabled ?? true;
//create token
$object = new token;
$token = $object->create($_SERVER['PHP_SELF']);

View File

@@ -151,6 +151,9 @@
unset($sql, $parameters);
}
//set the defaults
$profile_param_enabled = $profile_param_enabled ?? true;
//create token
$object = new token;
$token = $object->create($_SERVER['PHP_SELF']);

View File

@@ -313,7 +313,9 @@
}
//set the defaults
if (empty($conference_context)) { $conference_context = $_SESSION['domain_name']; }
$conference_profile = $conference_profile ?? 'default';
$conference_context = $conference_context ?? $_SESSION['domain_name'];
$conference_enabled = $conference_enabled ?? true;
//get the conference profiles
$sql = "select * ";
@@ -342,9 +344,6 @@
$users = $database->select($sql, $parameters ?? null, 'all');
unset($sql, $parameters);
//set the default
if (empty($conference_profile)) { $conference_profile = "default"; }
//create token
$object = new token;
$token = $object->create($_SERVER['PHP_SELF']);

View File

@@ -1484,8 +1484,9 @@
if (empty($destination_order)) { $destination_order = '100'; }
if (empty($destination_type)) { $destination_type = 'inbound'; }
if (empty($destination_context)) { $destination_context = 'public'; }
if ($destination_type =="outbound") { $destination_context = $_SESSION['domain_name']; }
if ($destination_type =="local") { $destination_context = $_SESSION['domain_name']; }
if ($destination_type == "outbound") { $destination_context = $_SESSION['domain_name']; }
if ($destination_type == "local") { $destination_context = $_SESSION['domain_name']; }
$destination_enabled = $destination_enabled ?? true;
//initialize the destinations object
if (permission_exists('destination_domain') && is_uuid($domain_uuid)) {

View File

@@ -55,6 +55,7 @@
}
else {
$action = "add";
$device_uuid = uuid();
}
//get the total device count from the database, check the limit, if defined
@@ -529,6 +530,10 @@
unset($sql, $parameters, $row);
}
//set the default values
$device_address = $device_address ?? '';
$device_enabled = $device_enabled ?? true;
//get device lines
$sql = "select * ";
$sql .= "from v_domains ";
@@ -536,9 +541,6 @@
$domains = $database->select($sql, null, 'all');
unset($sql, $parameters);
//set the defaults
$device_enabled = $device_enabled ?? true;
//use the device address to get the vendor
if (empty($device_vendor)) {
//get the device vendor using the device address
@@ -576,6 +578,8 @@
unset($sql, $parameters);
//set the new line defaults
$device_lines[$x]['device_uuid'] = '';
$device_lines[$x]['domain_name'] = '';
$device_lines[$x]['line_number'] = '';
$device_lines[$x]['server_address'] = '';
$device_lines[$x]['outbound_proxy_primary'] = $settings->get('provision', 'outbound_proxy_primary', null);

View File

@@ -428,6 +428,9 @@
exit;
}
//set the defaults
$dialplan_enabled = $dialplan_enabled ?? true;
//create token
$object = new token;
$token = $object->create($_SERVER['PHP_SELF']);
@@ -807,4 +810,4 @@
//include the footer
require_once "resources/footer.php";
?>
?>

View File

@@ -862,6 +862,9 @@
return;
}
//set the defaults
$dialplan_enabled = $dialplan_enabled ?? true;
//get the domains
$sql = "select * from v_domains ";
$sql .= "where domain_enabled = true ";

View File

@@ -17,7 +17,7 @@
The Initial Developer of the Original Code is
Mark J Crane <markjcrane@fusionpbx.com>
Portions created by the Initial Developer are Copyright (C) 2008-2023
Portions created by the Initial Developer are Copyright (C) 2008-2025
the Initial Developer. All Rights Reserved.
Contributor(s):
@@ -73,8 +73,9 @@
$dialplan_description = $_POST["dialplan_description"];
}
//set the default
if (empty($dialplan_context)) { $dialplan_context = $_SESSION['domain_name']; }
//set the defaults
$dialplan_context = $dialplan_context ?? $_SESSION['domain_name'];
$dialplan_enabled = $dialplan_enabled ?? true;
//add or update data from http post
if (count($_POST)>0 && empty($_POST["persistformvar"])) {

View File

@@ -390,15 +390,11 @@
unset($sql, $parameters);
//set the defaults
if (empty($dialplan_context)) {
$dialplan_context = $_SESSION['domain_name'];
}
if (empty($dialplan_order)) {
$dialplan_order = '200';
}
if (empty($dialplan_destination)) {
$dialplan_destination = false;
}
$dialplan_context = $dialplan_context ?? $_SESSION['domain_name'];
$dialplan_order = $dialplan_order ?? '200';
$dialplan_destination = $dialplan_destination ?? false;
$dialplan_continue = $dialplan_continue ?? true;
$dialplan_enabled = $dialplan_enabled ?? true;
//define the maximum dialplan order number
$dialplan_order_max = 999;

View File

@@ -1,7 +1,7 @@
<?php
/*
BSD-2-Clause License
Copyright (C) 2022-2023 Mark J Crane <markjcrane@fusionpbx.com>
Copyright (C) 2022-2025 Mark J Crane <markjcrane@fusionpbx.com>
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
@@ -237,7 +237,7 @@
$list_row_url = '';
if (permission_exists('event_guard_log_edit')) {
$list_row_url = "event_guard_log_edit.php?id=".urlencode($row['event_guard_log_uuid']);
if ($row['domain_uuid'] != $_SESSION['domain_uuid'] && permission_exists('domain_select')) {
if (!empty($row['domain_uuid']) && $row['domain_uuid'] != $_SESSION['domain_uuid'] && permission_exists('domain_select')) {
$list_row_url .= '&domain_uuid='.urlencode($row['domain_uuid']).'&domain_change=true';
}
}

View File

@@ -205,6 +205,9 @@
unset($sql, $parameters, $row);
}
//set the defaults
$extension_setting_enabled = $extension_setting_enabled ?? true;
//create token
$object = new token;
$token = $object->create($_SERVER['PHP_SELF']);
@@ -366,4 +369,4 @@
//include the footer
require_once "resources/footer.php";
?>
?>

View File

@@ -77,8 +77,8 @@
$provision_line_sip_port = $settings->get('provision','line_sip_port', null);
$provision_line_sip_transport = $settings->get('provision','line_sip_transport', null);
$provision_line_register_expires = $settings->get('provision','line_register_expires', null);
$theme_input_toggle_style = $settings->get('theme','input_toggle_style', ''); //set default to empty string
$voicemail_password_length = $settings->get('voicemail', 'password_length', 6); //set default to 6
$theme_input_toggle_style = $settings->get('theme','input_toggle_style', ''); //set default to empty string
$voicemail_password_length = $settings->get('voicemail', 'password_length', 6); //set default to 6
$voicemail_transcription_enabled_default = $settings->get('voicemail', 'transcription_enabled_default', false); //set default to false
$voicemail_enabled_default = $settings->get('voicemail', 'enabled_default', true);
$switch_voicemail = $settings->get('switch', 'voicemail', '/var/lib/freeswitch/storage/voicemail') . "/default/$domain_name";

View File

@@ -17,7 +17,7 @@
The Initial Developer of the Original Code is
Mark J Crane <markjcrane@fusionpbx.com>
Portions created by the Initial Developer are Copyright (C) 2008-2024
Portions created by the Initial Developer are Copyright (C) 2008-2025
the Initial Developer. All Rights Reserved.
Contributor(s):
@@ -38,6 +38,9 @@
$language = new text;
$text = $language->get();
//set the defaults
$fax_file = '';
//get the fax_extension and save it as a variable
if (isset($_REQUEST["fax_extension"])) {
$fax_extension = $_REQUEST["fax_extension"];
@@ -776,4 +779,4 @@
//show the footer
require_once "resources/footer.php";
?>
?>

View File

@@ -18,7 +18,7 @@
The Initial Developer of the Original Code is
Mark J Crane <markjcrane@fusionpbx.com>
Portions created by the Initial Developer are Copyright (C) 2024
Portions created by the Initial Developer are Copyright (C) 2024-2025
the Initial Developer. All Rights Reserved.
*/
@@ -36,6 +36,11 @@
$language = new text;
$text = $language->get();
//set the defaults
$fifo_strategy = '';
$fifo_exit_key = '';
$fifo_exit_action = '';
//add the settings object
$settings = new settings(["domain_uuid" => $_SESSION['domain_uuid'], "user_uuid" => $_SESSION['user_uuid']]);
@@ -419,6 +424,9 @@
unset($sql, $parameters, $row);
}
//set the defaults
$fifo_enabled = $fifo_enabled ?? true;
//get the child data
if (!empty($fifo_uuid) && is_uuid($fifo_uuid)) {
$sql = "select ";

View File

@@ -326,12 +326,12 @@
$profile = $profile ?? '';
$hostname = $hostname ?? '';
$description = $description ?? '';
$register = $register ?? false;
$register = $register ?? true;
$distinct_to = $distinct_to ?? false;
$caller_id_in_from = $caller_id_in_from ?? false;
$supress_cng = $supress_cng ?? false;
$contact_in_ping = $contact_in_ping ?? false;
$enabled = $enabled ?? false;
$enabled = $enabled ?? true;
//create token
$object = new token;

View File

@@ -46,6 +46,8 @@
$ivr_menu_name = '';
$ivr_menu_extension = '';
$ivr_menu_cid_prefix = '';
$ivr_menu_greet_long = '';
$ivr_menu_greet_short = '';
$ivr_menu_description = '';
$ivr_menu_ringback = $settings->get('ivr_menu','default_ringback', 'local_stream://default');

View File

@@ -17,7 +17,7 @@
The Initial Developer of the Original Code is
Mark J Crane <markjcrane@fusionpbx.com>
Portions created by the Initial Developer are Copyright (C) 2008-2023
Portions created by the Initial Developer are Copyright (C) 2008-2025
the Initial Developer. All Rights Reserved.
Contributor(s):
@@ -300,6 +300,9 @@
$recordings = $database->select($sql, $parameters, 'all');
unset($sql, $parameters);
//set the defaults
$phrase_enabled = $phrase_enabled ?? true;
//create token
$object = new token;
$token = $object->create($_SERVER['PHP_SELF']);

View File

@@ -588,8 +588,13 @@
}
//set the defaults
$ring_group_exit_key = $ring_group_exit_key ?? '';
$ring_group_call_timeout = $ring_group_call_timeout ?? '30';
$ring_group_greeting = $ring_group_greeting ?? '';
$ring_group_forward_enabled = $ring_group_forward_enabled ?? false;
$ring_group_context = $ring_group_context ?? $domain_name;
$ring_group_enabled = $ring_group_enabled ?? true;
$destination_enabled = $row['destination_enabled'] ?? false;
//get the ring group destination array
if ($action == "add") {
@@ -650,11 +655,6 @@
$users = $database->select($sql, $parameters, 'all');
unset($sql, $parameters);
//set the default ring group context
if (empty($ring_group_context)) {
$ring_group_context = $domain_name;
}
//get the ring backs
$ringbacks = new ringbacks;
$ringbacks = $ringbacks->select('ring_group_ringback', $ring_group_ringback);
@@ -983,8 +983,8 @@
echo " <span class='switch'>\n";
}
echo " <select class='formfld' id='ring_group_destinations_".$x."_destination_enabled' name='ring_group_destinations[".$x."][destination_enabled]'>\n";
echo " <option value='false' ".($row['destination_enabled'] === false ? "selected='selected'" : null).">".$text['option-false']."</option>\n";
echo " <option value='true' ".($row['destination_enabled'] === true ? "selected='selected'" : null).">".$text['option-true']."</option>\n";
echo " <option value='true' ".($destination_enabled === true ? "selected='selected'" : null).">".$text['option-true']."</option>\n";
echo " <option value='false' ".($destination_enabled === false ? "selected='selected'" : null).">".$text['option-false']."</option>\n";
echo " </select>\n";
if ($input_toggle_style_switch) {
echo " <span class='slider'></span>\n";
@@ -1252,8 +1252,8 @@
echo " <span class='switch'>\n";
}
echo " <select class='formfld' id='ring_group_forward_enabled' name='ring_group_forward_enabled' onchange=\"(this.selectedIndex == 1) ? document.getElementById('ring_group_forward_destination').focus() : null;\">\n";
echo " <option value='false' ".($ring_group_forward_enabled === false ? "selected='selected'" : null).">".$text['option-false']."</option>\n";
echo " <option value='true' ".($ring_group_forward_enabled === true ? "selected='selected'" : null).">".$text['option-true']."</option>\n";
echo " <option value='false' ".($ring_group_forward_enabled === false ? "selected='selected'" : null).">".$text['option-false']."</option>\n";
echo " </select>\n";
if ($input_toggle_style_switch) {
echo " <span class='slider'></span>\n";

View File

@@ -355,6 +355,9 @@
}
unset($sql);
//set the defaults
$sip_profile_enabled = $sip_profile_enabled ?? true;
//create token
$object = new token;
$token = $object->create($_SERVER['PHP_SELF']);

View File

@@ -232,6 +232,9 @@
return;
}
//set the defaults
$stream_enabled = $stream_enabled ?? true;
//create token
$object = new token;
$token = $object->create($_SERVER['PHP_SELF']);

View File

@@ -646,7 +646,8 @@
}
//set the defaults
if (empty($dialplan_context)) { $dialplan_context = $_SESSION['domain_name']; }
$dialplan_context = $dialplan_context ?? $_SESSION['domain_name'];
$dialplan_enabled = $dialplan_enabled ?? true;
//create token
$object = new token;
@@ -1330,4 +1331,4 @@ if ($action == 'update') {
//include the footer
require_once "resources/footer.php";
?>
?>

View File

@@ -175,6 +175,9 @@
unset($sql, $parameters);
}
//set the defaults
$var_enabled = $var_enabled ?? true;
//create token
$object = new token;
$token = $object->create($_SERVER['PHP_SELF']);

View File

@@ -377,12 +377,12 @@
}
//set the defaults
if (!isset($voicemail_local_after_email)) { $voicemail_local_after_email = true; }
if (!isset($voicemail_enabled)) { $voicemail_enabled = $settings->get('voicemail', 'enabled_default', true); }
if (!isset($voicemail_transcription_enabled)) { $voicemail_transcription_enabled = $settings->get('voicemail', 'transcription_enabled_default', false); }
if (!isset($voicemail_tutorial)) { $voicemail_tutorial = false; }
if (!isset($voicemail_recording_instructions)) { $voicemail_recording_instructions = true; }
if (!isset($voicemail_recording_options)) { $voicemail_recording_options = true; }
$voicemail_local_after_email = $voicemail_local_after_email ?? true;
$voicemail_enabled = $voicemail_enabled ?? $settings->get('voicemail', 'enabled_default', true);
$voicemail_transcription_enabled = $voicemail_transcription_enabled ?? $settings->get('voicemail', 'transcription_enabled_default', false);
$voicemail_tutorial = $voicemail_tutorial ?? false;
$voicemail_recording_instructions = $voicemail_recording_instructions ?? true;
$voicemail_recording_options = $voicemail_recording_options ?? true;
//get the greetings list
$sql = "select * from v_voicemail_greetings ";

View File

@@ -63,6 +63,8 @@
$remote_media_ip = "";
$network_addr = "";
$mos_score = "";
$call_center_queue_uuid = "";
$ring_group_uuid = "";
//get the list of extensions
$sql = "select extension_uuid, extension, number_alias from v_extensions ";