From 8f71f5cf4b2bf0cad192f0d9b20160120cacceab Mon Sep 17 00:00:00 2001
From: frytimo <tim.fry@hotmail.com>
Date: Fri, 19 Jul 2024 20:39:19 -0300
Subject: [PATCH] reduce permission_exists calls from 7,000+ to just 7 (#7056)

Authored-by: Tim Fry <tim@fusionpbx.com>
---
 core/default_settings/default_settings.php | 48 +++++++++++++---------
 1 file changed, 28 insertions(+), 20 deletions(-)

diff --git a/core/default_settings/default_settings.php b/core/default_settings/default_settings.php
index 7900fe69ec..8647656315 100644
--- a/core/default_settings/default_settings.php
+++ b/core/default_settings/default_settings.php
@@ -37,6 +37,14 @@
 		exit;
 	}
 
+//set permissions
+	$has_add = permission_exists('default_setting_add');
+	$has_all = permission_exists('default_setting_all');
+	$has_edit = permission_exists('default_setting_edit');
+	$has_delete = permission_exists('default_setting_delete');
+	$has_domain_select = permission_exists('domain_select');
+	$has_domain_setting_add = permission_exists('domain_setting_add');
+
 //add multi-lingual support
 	$language = new text;
 	$text = $language->get();
@@ -80,20 +88,20 @@
 	if (!empty($action) && !empty($default_settings)) {
 		switch ($action) {
 			case 'copy':
-				if (permission_exists('default_setting_add')) {
+				if ($has_add) {
 					$obj = new default_settings;
 					$obj->domain_uuid = $domain_uuid;
 					$obj->copy($default_settings);
 				}
 				break;
 			case 'toggle':
-				if (permission_exists('default_setting_edit')) {
+				if ($has_edit) {
 					$obj = new default_settings;
 					$obj->toggle($default_settings);
 				}
 				break;
 			case 'delete':
-				if (permission_exists('default_setting_delete')) {
+				if ($has_delete) {
 					$obj = new default_settings;
 					$obj->delete($default_settings);
 				}
@@ -248,7 +256,7 @@
 	require_once "resources/header.php";
 
 //copy settings javascript
-	if (permission_exists("domain_select") && permission_exists("domain_setting_add")) {
+	if ($has_domain_select && $has_domain_setting_add) {
 		echo "<script language='javascript' type='text/javascript'>\n";
 		echo "	function show_domains() {\n";
 		echo "		document.getElementById('action').value = 'copy';\n";
@@ -274,11 +282,11 @@
 	echo "	<div class='actions'>\n";
 	echo button::create(['type'=>'button','label'=>$text['label-domain'],'icon'=>$_SESSION['theme']['button_icon_domain'],'style'=>'','link'=>PROJECT_PATH.'/core/domain_settings/domain_settings.php?id='.$domain_uuid]);
 	echo button::create(['label'=>$text['button-reload'],'icon'=>$_SESSION['theme']['button_icon_reload'],'type'=>'button','id'=>'button_reload','link'=>'default_settings_reload.php'.(!empty($search) ? '?search='.urlencode($search) : null),'style'=>'margin-right: 15px;']);
-	if (permission_exists('default_setting_add')) {
+	if ($has_add) {
 		echo button::create(['type'=>'button','label'=>$text['button-add'],'icon'=>$_SESSION['theme']['button_icon_add'],'id'=>'btn_add','link'=>'default_setting_edit.php?'.$query_string]);
 	}
-	if (permission_exists('default_setting_add') && !empty($default_settings)) {
-		if (permission_exists("domain_select") && permission_exists("domain_setting_add")) {
+	if ($has_add && !empty($default_settings)) {
+		if ($has_domain_select && $has_domain_setting_add) {
 			echo button::create(['type'=>'button','label'=>$text['button-copy'],'id'=>'btn_copy','name'=>'btn_copy','style'=>'display: none;','icon'=>$_SESSION['theme']['button_icon_copy'],'id'=>'btn_copy','onclick'=>'show_domains();']);
 			echo button::create(['type'=>'button','label'=>$text['button-cancel'],'id'=>'btn_copy_cancel','icon'=>$_SESSION['theme']['button_icon_cancel'],'style'=>'display: none;','onclick'=>'hide_domains();']);
 			echo 		"<select name='domain_uuid' class='formfld' style='display: none; width: auto;' id='target_domain_uuid' onchange=\"document.getElementById('domain_uuid').value = this.options[this.selectedIndex].value;\">\n";
@@ -291,10 +299,10 @@
 			echo button::create(['type'=>'button','label'=>$text['button-paste'],'icon'=>$_SESSION['theme']['button_icon_paste'],'id'=>'btn_paste','style'=>'display: none;','onclick'=>"if (confirm('".$text['confirm-copy']."')) { list_action_set('copy'); list_form_submit('form_list'); } else { this.blur(); return false; }"]);
 		}
 	}
-	if (permission_exists('default_setting_edit') && $default_settings) {
+	if ($has_edit && $default_settings) {
 		echo button::create(['type'=>'button','label'=>$text['button-toggle'],'icon'=>$_SESSION['theme']['button_icon_toggle'],'id'=>'btn_toggle','name'=>'btn_toggle','style'=>'display: none;','onclick'=>"modal_open('modal-toggle','btn_toggle');"]);
 	}
-	if (permission_exists('default_setting_delete') && $default_settings) {
+	if ($has_delete && $default_settings) {
 		echo button::create(['type'=>'button','label'=>$text['button-delete'],'icon'=>$_SESSION['theme']['button_icon_delete'],'id'=>'btn_delete','name'=>'btn_delete','style'=>'display: none;','onclick'=>"modal_open('modal-delete','btn_delete');"]);
 	}
 	echo 		"<form id='form_search' class='inline' method='get'>\n";
@@ -321,10 +329,10 @@
 	echo "	<div style='clear: both;'></div>\n";
 	echo "</div>\n";
 
-	if (permission_exists('default_setting_edit') && $default_settings) {
+	if ($has_edit && $default_settings) {
 		echo modal::create(['id'=>'modal-toggle','type'=>'toggle','actions'=>button::create(['type'=>'button','label'=>$text['button-continue'],'icon'=>'check','id'=>'btn_toggle','style'=>'float: right; margin-left: 15px;','collapse'=>'never','onclick'=>"modal_close(); list_action_set('toggle'); list_form_submit('form_list');"])]);
 	}
-	if (permission_exists('default_setting_delete') && $default_settings) {
+	if ($has_delete && $default_settings) {
 		echo modal::create(['id'=>'modal-delete','type'=>'delete','actions'=>button::create(['type'=>'button','label'=>$text['button-continue'],'icon'=>'check','id'=>'btn_delete','style'=>'float: right; margin-left: 15px;','collapse'=>'never','onclick'=>"modal_close(); list_action_set('delete'); list_form_submit('form_list');"])]);
 	}
 
@@ -405,12 +413,12 @@
 
 				echo "<table class='list'>\n";
 				echo "<tr class='list-header'>\n";
-				if (permission_exists('default_setting_add') || permission_exists('default_setting_edit') || permission_exists('default_setting_delete')) {
+				if ($has_add || $has_edit || $has_delete) {
 					echo "	<th class='checkbox'>\n";
 					echo "		<input type='checkbox' id='checkbox_all_".$default_setting_category."' name='checkbox_all' onclick=\"list_all_toggle('".$default_setting_category."'); checkbox_on_change(this);\">\n";
 					echo "	</th>\n";
 				}
-				if ($show == 'all' && permission_exists('default_setting_all')) {
+				if ($show == 'all' && $has_all) {
 					echo th_order_by('domain_name', $text['label-domain'], $order_by, $order);
 				}
 				echo th_order_by('default_setting_subcategory', $text['label-subcategory'], $order_by, $order, null, "class='pct-35'");
@@ -418,26 +426,26 @@
 				echo th_order_by('default_setting_value', $text['label-value'], $order_by, $order, null, "class='pct-30'");
 				echo th_order_by('default_setting_enabled', $text['label-enabled'], $order_by, $order, null, "class='center'");
 				echo "	<th class='pct-25 hide-sm-dn'>".$text['label-description']."</th>\n";
-				if (permission_exists('default_setting_edit') && $list_row_edit_button == 'true') {
+				if ($has_edit && $list_row_edit_button == 'true') {
 					echo "	<td class='action-button'>&nbsp;</td>\n";
 				}
 				echo "</tr>\n";
 			}
-			if (permission_exists('default_setting_edit')) {
+			if ($has_edit) {
 				$list_row_url = "default_setting_edit.php?id=".urlencode($row['default_setting_uuid']).'&'.$query_string;
 			}
 			echo "<tr class='list-row' href='".$list_row_url."'>\n";
-			if (permission_exists('default_setting_add') || permission_exists('default_setting_edit') || permission_exists('default_setting_delete')) {
+			if ($has_add || $has_edit || $has_delete) {
 				echo "	<td class='checkbox'>\n";
 				echo "		<input type='checkbox' name='default_settings[$x][checked]' id='checkbox_".$x."' class='checkbox_".$default_setting_category."' value='true' onclick=\"checkbox_on_change(this); if (!this.checked) { document.getElementById('checkbox_all_".$default_setting_category."').checked = false; }\">\n";
 				echo "		<input type='hidden' name='default_settings[$x][uuid]' value='".escape($row['default_setting_uuid'])."' />\n";
 				echo "	</td>\n";
 			}
-			if ($show == 'all' && permission_exists('default_setting_all')) {
+			if ($show == 'all' && $has_all) {
 				echo "	<td>".escape($_SESSION['domains'][$row['domain_uuid']]['domain_name'])."</td>\n";
 			}
 			echo "	<td class='overflow no-wrap'>";
-			if (permission_exists('default_setting_edit')) {
+			if ($has_edit) {
 				echo "<a href='".$list_row_url."'>".escape($row['default_setting_subcategory'])."</a>";
 			}
 			else {
@@ -548,7 +556,7 @@
 				}
 			}
 			echo "	</td>\n";
-			if (permission_exists('default_setting_edit')) {
+			if ($has_edit) {
 				echo "	<td class='no-link center'>\n";
 				if (!empty($enabled_bold)) {
 					echo button::create(['type'=>'submit','class'=>'link','style'=>'font-weight:bold', 'label'=>$text['label-'.$row['default_setting_enabled']],'title'=>$text['button-toggle'],'onclick'=>"list_self_check('checkbox_".$x."'); list_action_set('toggle'); list_form_submit('form_list')"]);
@@ -563,7 +571,7 @@
 			}
 			echo "	</td>\n";
 			echo "	<td class='description overflow hide-sm-dn' title=\"".escape($row['default_setting_description'])."\">".escape($row['default_setting_description'])."</td>\n";
-			if (permission_exists('default_setting_edit') && $list_row_edit_button == 'true') {
+			if ($has_edit && $list_row_edit_button == 'true') {
 				echo "	<td class='action-button'>\n";
 				echo button::create(['type'=>'button','title'=>$text['button-edit'],'icon'=>$_SESSION['theme']['button_icon_edit'],'link'=>$list_row_url]);
 				echo "	</td>\n";