diff --git a/app/devices/device_vendors.php b/app/devices/device_vendors.php index 97202c2604..ac13f1b986 100644 --- a/app/devices/device_vendors.php +++ b/app/devices/device_vendors.php @@ -17,7 +17,7 @@ The Initial Developer of the Original Code is Mark J Crane - Portions created by the Initial Developer are Copyright (C) 2016 + Portions created by the Initial Developer are Copyright (C) 2016-2023 the Initial Developer. All Rights Reserved. Contributor(s): @@ -47,14 +47,14 @@ $text = $language->get(); //get posted data - if (is_array($_POST['vendors'])) { + if (!empty($_POST['vendors']) && is_array($_POST['vendors'])) { $action = $_POST['action']; $search = $_POST['search']; $vendors = $_POST['vendors']; } //process the http post data by action - if ($action != '' && is_array($vendors) && @sizeof($vendors) != 0) { + if (!empty($action) && !empty($vendors) && is_array($vendors) && @sizeof($vendors) != 0) { switch ($action) { case 'toggle': if (permission_exists('device_vendor_edit')) { @@ -75,11 +75,11 @@ } //get variables used to control the order - $order_by = $_GET["order_by"]; - $order = $_GET["order"]; + $order_by = $_GET["order_by"] ?? null; + $order = $_GET["order"] ?? null; //add the search term - $search = strtolower($_GET["search"]); + $search = strtolower($_GET["search"] ?? ''); if (!empty($search)) { $sql_where = "where ("; $sql_where .= "lower(name) like :search "; @@ -91,14 +91,14 @@ //prepare to page the results $sql = "select count(*) from v_device_vendors "; - $sql .= $sql_where; + $sql .= $sql_where ?? null; $database = new database; - $num_rows = $database->select($sql, $parameters, 'column'); + $num_rows = $database->select($sql, $parameters ?? null, 'column'); //prepare to page the results $rows_per_page = ($_SESSION['domain']['paging']['numeric'] != '') ? $_SESSION['domain']['paging']['numeric'] : 50; $param = "&search=".$search; - $page = $_GET['page']; + $page = $_GET['page'] ?? null; if (empty($page)) { $page = 0; $_GET['page'] = 0; } list($paging_controls, $rows_per_page) = paging($num_rows, $param, $rows_per_page); list($paging_controls_mini, $rows_per_page) = paging($num_rows, $param, $rows_per_page, true); @@ -109,7 +109,7 @@ $sql .= order_by($order_by, $order, 'name', 'asc'); $sql .= limit_offset($rows_per_page, $offset); $database = new database; - $result = $database->select($sql, $parameters, 'all'); + $result = $database->select($sql, $parameters ?? null, 'all'); unset($sql, $parameters); //create token @@ -168,13 +168,13 @@ echo "\n"; if (permission_exists('device_vendor_edit') || permission_exists('device_vendor_delete')) { echo " \n"; - echo " \n"; + echo " \n"; echo " \n"; } echo th_order_by('name', $text['label-name'], $order_by, $order); echo th_order_by('enabled', $text['label-enabled'], $order_by, $order, null, "class='center'"); echo th_order_by('description', $text['label-description'], $order_by, $order, null, "class='hide-xs'"); - if (permission_exists('device_vendor_edit') && $_SESSION['theme']['list_row_edit_button']['boolean'] == 'true') { + if (permission_exists('device_vendor_edit') && !empty($_SESSION['theme']['list_row_edit_button']['boolean']) && $_SESSION['theme']['list_row_edit_button']['boolean'] == 'true') { echo "  \n"; } echo "\n"; @@ -202,7 +202,7 @@ echo $text['label-'.$row['enabled']]; } echo " ".escape($row['description'])." \n"; - if (permission_exists('device_vendor_edit') && $_SESSION['theme']['list_row_edit_button']['boolean'] == 'true') { + if (permission_exists('device_vendor_edit') && !empty($_SESSION['theme']['list_row_edit_button']['boolean']) && $_SESSION['theme']['list_row_edit_button']['boolean'] == 'true') { echo " "; echo button::create(['type'=>'button','title'=>$text['button-edit'],'icon'=>$_SESSION['theme']['button_icon_edit'],'link'=>$list_row_url]); echo " \n"; @@ -224,4 +224,4 @@ //include the footer require_once "resources/footer.php"; -?> +?> \ No newline at end of file