From 787205bcd54c63c2d40b87a6b464c1ab19036dd0 Mon Sep 17 00:00:00 2001
From: Mark Crane <markjcrane@gmail.com>
Date: Sat, 4 Jan 2014 07:45:06 +0000
Subject: [PATCH] Fix permissions checks that were missed in ring_groups.php

---
 app/ring_groups/ring_group_delete.php |  2 +-
 app/ring_groups/ring_groups.php       | 16 ++++++++++++----
 2 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/app/ring_groups/ring_group_delete.php b/app/ring_groups/ring_group_delete.php
index fa6ee200d0..daa19a4b33 100644
--- a/app/ring_groups/ring_group_delete.php
+++ b/app/ring_groups/ring_group_delete.php
@@ -27,7 +27,7 @@
 require_once "root.php";
 require_once "resources/require.php";
 require_once "resources/check_auth.php";
-if (permission_exists('ring_group_add')) {
+if (permission_exists('ring_group_delete')) {
 	//access granted
 }
 else {
diff --git a/app/ring_groups/ring_groups.php b/app/ring_groups/ring_groups.php
index f370a345c2..0956349089 100644
--- a/app/ring_groups/ring_groups.php
+++ b/app/ring_groups/ring_groups.php
@@ -119,7 +119,9 @@ require_once "resources/paging.php";
 	echo th_order_by('ring_group_enabled', $text['label-enabled'], $order_by, $order);
 	echo th_order_by('ring_group_description', $text['label-description'], $order_by, $order);
 	echo "<td align='right' width='42'>\n";
-	echo "	<a href='ring_group_edit.php' alt='add'>$v_link_label_add</a>\n";
+	if (permission_exists('ring_group_add')) {
+		echo "	<a href='ring_group_edit.php' alt='add'>$v_link_label_add</a>\n";
+	}
 	echo "</td>\n";
 	echo "<tr>\n";
 
@@ -136,8 +138,12 @@ require_once "resources/paging.php";
 			echo "	<td valign='top' class='".$row_style[$c]."'>".$row['ring_group_enabled']."&nbsp;</td>\n";
 			echo "	<td valign='top' class='".$row_style[$c]."'>".$row['ring_group_description']."&nbsp;</td>\n";
 			echo "	<td valign='top' align='right'>\n";
-			echo "		<a href='ring_group_edit.php?id=".$row['ring_group_uuid']."' alt='edit'>$v_link_label_edit</a>\n";
-			echo "		<a href='ring_group_delete.php?id=".$row['ring_group_uuid']."' alt='delete' onclick=\"return confirm('".$text['confirm-delete']."')\">$v_link_label_delete</a>\n";
+			if (permission_exists('ring_group_edit')) {
+				echo "		<a href='ring_group_edit.php?id=".$row['ring_group_uuid']."' alt='edit'>$v_link_label_edit</a>\n";
+			}
+			if (permission_exists('ring_group_delete')) {
+				echo "		<a href='ring_group_delete.php?id=".$row['ring_group_uuid']."' alt='delete' onclick=\"return confirm('".$text['confirm-delete']."')\">$v_link_label_delete</a>\n";
+			}
 			echo "	</td>\n";
 			echo "</tr>\n";
 			if ($c==0) { $c=1; } else { $c=0; }
@@ -152,7 +158,9 @@ require_once "resources/paging.php";
 	echo "		<td width='33.3%' nowrap>&nbsp;</td>\n";
 	echo "		<td width='33.3%' align='center' nowrap>$paging_controls</td>\n";
 	echo "		<td width='33.3%' align='right'>\n";
-	echo "			<a href='ring_group_edit.php' alt='add'>$v_link_label_add</a>\n";
+	if (permission_exists('ring_group_add')) {
+		echo "			<a href='ring_group_edit.php' alt='add'>$v_link_label_add</a>\n";
+	}
 	echo "		</td>\n";
 	echo "	</tr>\n";
  	echo "	</table>\n";